* Re: linux-next: Tree for July 6 (NET_DSA + PHYLIB kconfig) [not found] <20100706190519.93d8b785.sfr@canb.auug.org.au> @ 2010-07-06 17:34 ` Randy Dunlap 2010-07-11 2:09 ` David Miller 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2010-07-06 17:34 UTC (permalink / raw) To: Stephen Rothwell, netdev; +Cc: linux-next, LKML On Tue, 6 Jul 2010 19:05:19 +1000 Stephen Rothwell wrote: > Hi all, > > Changes since 20100705: > > My fixes tree contains: > kbuild: Fix path to scripts/setlocalversion > > ---------------------------------------------------------------------------- kconfig now detects symbol dependency errors and warns about them. E.g.: warning: (NET_DSA && NET && EXPERIMENTAL && !S390 || MACB && NETDEVICES && NET_ETHERNET && (AVR32 || ARCH_AT91SAM9260 || ARCH_AT91SAM9263 || ARCH_AT91SAM9G20 || ARCH_AT91SAM9G45 || ARCH_AT91CAP9) || IXP4XX_ETH && NETDEVICES && NET_ETHERNET && ARM && ARCH_IXP4XX && IXP4XX_NPE && IXP4XX_QMGR || W90P910_ETH && NETDEVICES && NET_ETHERNET && ARM && ARCH_W90X900 || MIPS_AU1X00_ENET && NETDEVICES && NET_ETHERNET && SOC_AU1X00 || SH_ETH && NETDEVICES && NET_ETHERNET && SUPERH && (CPU_SUBTYPE_SH7710 {{20 lines deleted}} selects PHYLIB which has unmet direct dependencies (!S390 && NET_ETHERNET) says that NET_DSA & PHYLIB have some kind of problem. NET_DSA selects PHYLIB. PHYLIB depends on NET_ETHERNET, which is not enabled in this randconfig. net/dsa code does need PHYLIB code, so PHYLIB symbol should either drop "depends on NET_ETHERNET" or it should be changed to depends on NET_ETHERNET || NET_DSA Preference? --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for July 6 (NET_DSA + PHYLIB kconfig) 2010-07-06 17:34 ` linux-next: Tree for July 6 (NET_DSA + PHYLIB kconfig) Randy Dunlap @ 2010-07-11 2:09 ` David Miller 2010-07-20 23:03 ` [PATCH -next] net: NET_DSA depends on NET_ETHERNET Randy Dunlap 0 siblings, 1 reply; 5+ messages in thread From: David Miller @ 2010-07-11 2:09 UTC (permalink / raw) To: randy.dunlap; +Cc: sfr, netdev, linux-next, linux-kernel From: Randy Dunlap <randy.dunlap@oracle.com> Date: Tue, 6 Jul 2010 10:34:17 -0700 > NET_DSA selects PHYLIB. PHYLIB depends on NET_ETHERNET, which is not enabled > in this randconfig. net/dsa code does need PHYLIB code, so PHYLIB symbol should > either drop "depends on NET_ETHERNET" or it should be changed to > depends on NET_ETHERNET || NET_DSA > > Preference? The situations seems to suggest NET_DSA depends upon NET_ETHERNET, so adding NET_ETHERNET to NET_DSA's dependencies probably works better. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH -next] net: NET_DSA depends on NET_ETHERNET 2010-07-11 2:09 ` David Miller @ 2010-07-20 23:03 ` Randy Dunlap 2010-07-21 0:45 ` David Miller 0 siblings, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2010-07-20 23:03 UTC (permalink / raw) To: David Miller; +Cc: sfr, netdev, linux-next, linux-kernel, Lennert Buytenhek From: Randy Dunlap <randy.dunlap@oracle.com> NET_DSA code selects and uses PHYLIB code, but PHYLIB depends on NET_ETHERNET. However, "select" does not follow kconfig dependencies, so explicitly list that requirement here instead. Fixes this kconfig warning: warning: (NET_DSA && NET && EXPERIMENTAL && !S390 ...) selects PHYLIB which has unmet direct dependencies (!S390 && NET_ETHERNET) Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Lennert Buytenhek <buytenh@wantstofly.org> --- net/dsa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Is there some reason that NET_DSA is bool instead of tristate? I.e., net/dsa/ code cannot be built as loadable modules? --- linux-next-20100713.orig/net/dsa/Kconfig +++ linux-next-20100713/net/dsa/Kconfig @@ -1,7 +1,7 @@ menuconfig NET_DSA bool "Distributed Switch Architecture support" default n - depends on EXPERIMENTAL && !S390 + depends on EXPERIMENTAL && !S390 && NET_ETHERNET select PHYLIB ---help--- This allows you to use hardware switch chips that use ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] net: NET_DSA depends on NET_ETHERNET 2010-07-20 23:03 ` [PATCH -next] net: NET_DSA depends on NET_ETHERNET Randy Dunlap @ 2010-07-21 0:45 ` David Miller 2010-07-21 5:41 ` Randy Dunlap 0 siblings, 1 reply; 5+ messages in thread From: David Miller @ 2010-07-21 0:45 UTC (permalink / raw) To: randy.dunlap; +Cc: sfr, netdev, linux-next, linux-kernel, buytenh From: Randy Dunlap <randy.dunlap@oracle.com> Date: Tue, 20 Jul 2010 16:03:32 -0700 > From: Randy Dunlap <randy.dunlap@oracle.com> > > NET_DSA code selects and uses PHYLIB code, but PHYLIB depends on > NET_ETHERNET. However, "select" does not follow kconfig dependencies, > so explicitly list that requirement here instead. > > Fixes this kconfig warning: > > warning: (NET_DSA && NET && EXPERIMENTAL && !S390 ...) selects PHYLIB which has unmet direct dependencies (!S390 && NET_ETHERNET) > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Randy, this has been fixed in net-2.6 for some time now. And I'm pretty sure I sent a copy of this to you when I checked it in :-) -------------------- >From 336a283b9cbe47748ccd68fd8c5158f67cee644b Mon Sep 17 00:00:00 2001 From: David S. Miller <davem@davemloft.net> Date: Mon, 12 Jul 2010 20:03:42 -0700 Subject: [PATCH 09/24] dsa: Fix Kconfig dependencies. Based upon a report by Randy Dunlap. DSA needs PHYLIB, but PHYLIB needs NET_ETHERNET. So, in order to select PHYLIB we have to make DSA depend upon NET_ETHERNET. Signed-off-by: David S. Miller <davem@davemloft.net> --- net/dsa/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index c51b554..1120178 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -1,7 +1,7 @@ menuconfig NET_DSA bool "Distributed Switch Architecture support" default n - depends on EXPERIMENTAL && !S390 + depends on EXPERIMENTAL && NET_ETHERNET && !S390 select PHYLIB ---help--- This allows you to use hardware switch chips that use -- 1.7.1.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] net: NET_DSA depends on NET_ETHERNET 2010-07-21 0:45 ` David Miller @ 2010-07-21 5:41 ` Randy Dunlap 0 siblings, 0 replies; 5+ messages in thread From: Randy Dunlap @ 2010-07-21 5:41 UTC (permalink / raw) To: David Miller; +Cc: sfr, netdev, linux-next, linux-kernel, buytenh On 07/20/10 17:45, David Miller wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > Date: Tue, 20 Jul 2010 16:03:32 -0700 > >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> NET_DSA code selects and uses PHYLIB code, but PHYLIB depends on >> NET_ETHERNET. However, "select" does not follow kconfig dependencies, >> so explicitly list that requirement here instead. >> >> Fixes this kconfig warning: >> >> warning: (NET_DSA && NET && EXPERIMENTAL && !S390 ...) selects PHYLIB which has unmet direct dependencies (!S390 && NET_ETHERNET) >> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Randy, this has been fixed in net-2.6 for some time now. OK, I did see the commit get merged today. > And I'm pretty sure I sent a copy of this to you when I > checked it in :-) I missed it somehow. Thanks. > -------------------- > From 336a283b9cbe47748ccd68fd8c5158f67cee644b Mon Sep 17 00:00:00 2001 > From: David S. Miller <davem@davemloft.net> > Date: Mon, 12 Jul 2010 20:03:42 -0700 > Subject: [PATCH 09/24] dsa: Fix Kconfig dependencies. > > Based upon a report by Randy Dunlap. > > DSA needs PHYLIB, but PHYLIB needs NET_ETHERNET. So, in order > to select PHYLIB we have to make DSA depend upon NET_ETHERNET. > > Signed-off-by: David S. Miller <davem@davemloft.net> > --- > net/dsa/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig > index c51b554..1120178 100644 > --- a/net/dsa/Kconfig > +++ b/net/dsa/Kconfig > @@ -1,7 +1,7 @@ > menuconfig NET_DSA > bool "Distributed Switch Architecture support" > default n > - depends on EXPERIMENTAL && !S390 > + depends on EXPERIMENTAL && NET_ETHERNET && !S390 > select PHYLIB > ---help--- > This allows you to use hardware switch chips that use -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-07-21 5:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100706190519.93d8b785.sfr@canb.auug.org.au>
2010-07-06 17:34 ` linux-next: Tree for July 6 (NET_DSA + PHYLIB kconfig) Randy Dunlap
2010-07-11 2:09 ` David Miller
2010-07-20 23:03 ` [PATCH -next] net: NET_DSA depends on NET_ETHERNET Randy Dunlap
2010-07-21 0:45 ` David Miller
2010-07-21 5:41 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).