From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: bhutchings@solarflare.com, sassmann@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
gospo@redhat.com, gregory.v.rose@intel.com,
alexander.h.duyck@intel.com, leedom@chelsio.com,
harald@redhat.com
Subject: Re: [PATCH net-next] sysfs: add entry to indicate network interfaces with random MAC address
Date: Tue, 20 Jul 2010 14:18:16 -0700 [thread overview]
Message-ID: <20100720141816.16f0a939@nehalam> (raw)
In-Reply-To: <20100720.131748.51255156.davem@davemloft.net>
On Tue, 20 Jul 2010 13:17:48 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Tue, 20 Jul 2010 15:29:54 +0100
>
> > On Tue, 2010-07-20 at 14:41 +0200, Stefan Assmann wrote:
> >> Btw, the driver itself could also alter the flag. Then we'd have a well
> >> defined way of setting a stable address.
> >
> > The driver can't know whether an address assigned by the user is stable.
>
> If userspace can somehow obtain a persistent address, it can kick
> udev too.
>
> I really don't see any real value provided by letting userspace mess
> with this. Because the permanence communicated in this value is from
> the perspective of the kernel driver, it's really therefore about the
> thing that's in ->perm_addr[] not what happens to be in ->addr[] right
> now.
No one mentioned that the first octet of an Ethernet address already
indicates "software generated" Ethernet address. Per the standard,
if bit 1 is set it means address is locally assigned.
static inline bool is_locally_assigned_ether(const u8 *addr)
{
return (addr[0] & 0x2) != 0;
}
next prev parent reply other threads:[~2010-07-20 21:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 10:50 [PATCH net-next] sysfs: add entry to indicate network interfaces with random MAC address Stefan Assmann
2010-07-20 11:20 ` Ben Hutchings
2010-07-20 11:47 ` Stefan Assmann
2010-07-20 11:58 ` Alex Badea
2010-07-20 12:17 ` Stefan Assmann
2010-07-20 20:18 ` David Miller
2010-07-21 8:10 ` Stefan Assmann
2010-07-21 13:54 ` Ben Hutchings
2010-07-22 12:50 ` [PATCH net-next] sysfs: add attribute to indicate hw address assignment type Stefan Assmann
2010-07-22 14:07 ` Ben Hutchings
2010-07-22 14:47 ` Stefan Assmann
2010-07-25 3:50 ` David Miller
2010-07-20 12:07 ` [PATCH net-next] sysfs: add entry to indicate network interfaces with random MAC address Ben Hutchings
2010-07-20 12:41 ` Stefan Assmann
2010-07-20 14:29 ` Ben Hutchings
2010-07-20 20:17 ` David Miller
2010-07-20 21:18 ` Stephen Hemminger [this message]
2010-07-20 21:20 ` David Miller
2010-07-21 6:26 ` Harald Hoyer
2010-07-21 6:34 ` David Miller
2010-07-21 6:47 ` Harald Hoyer
2010-07-21 15:07 ` Andy Gospodarek
2010-07-21 16:34 ` Casey Leedom
2010-07-21 17:28 ` Stephen Hemminger
2010-07-21 17:32 ` David Miller
2010-07-21 18:29 ` Casey Leedom
2010-07-21 18:39 ` David Miller
2010-07-21 19:25 ` Casey Leedom
2010-07-21 18:43 ` Rose, Gregory V
2010-07-21 18:48 ` David Miller
2010-07-21 18:50 ` David Miller
2010-07-21 19:02 ` Rose, Gregory V
2010-07-21 19:33 ` David Miller
2010-07-21 19:35 ` Rose, Gregory V
2010-07-22 7:12 ` Ian Campbell
2010-07-22 6:53 ` Stefan Assmann
2010-07-23 0:26 ` Casey Leedom
2010-07-23 8:08 ` Stefan Assmann
2010-07-23 16:35 ` Casey Leedom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720141816.16f0a939@nehalam \
--to=shemminger@vyatta.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=harald@redhat.com \
--cc=leedom@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).