From: Jean Delvare <jdelvare@suse.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Bruce Allan <bruce.w.allan@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: [PATCH] e1000e: Fix irq_synchronize in MSI-X case
Date: Tue, 20 Jul 2010 17:12:05 +0200 [thread overview]
Message-ID: <201007201712.05671.jdelvare@suse.de> (raw)
Synchronize all IRQs when in MSI-X IRQ mode.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Bruce Allan <bruce.w.allan@intel.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
I sent this patch to the e1000-devel list on June 8th, 2010, but
didn't receive any answer:
http://sourceforge.net/mailarchive/forum.php?thread_name=201006081818.59098.jdelvare%40suse.de&forum_name=e1000-devel
I don't know how critical synchronize_irq() is, so I don't know if
this patch should go to stable branches or not.
drivers/net/e1000e/netdev.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -1939,7 +1939,13 @@ static void e1000_irq_disable(struct e10
if (adapter->msix_entries)
ew32(EIAC_82574, 0);
e1e_flush();
- synchronize_irq(adapter->pdev->irq);
+
+ if (adapter->msix_entries) {
+ synchronize_irq(adapter->msix_entries[0].vector);
+ synchronize_irq(adapter->msix_entries[1].vector);
+ synchronize_irq(adapter->msix_entries[2].vector);
+ } else
+ synchronize_irq(adapter->pdev->irq);
}
/**
--
Jean Delvare
Suse L3
next reply other threads:[~2010-07-20 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 15:12 Jean Delvare [this message]
2010-07-21 20:38 ` [PATCH] e1000e: Fix irq_synchronize in MSI-X case Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007201712.05671.jdelvare@suse.de \
--to=jdelvare@suse.de \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox