* [PATCH 0/3 net-2.6] bnx2x: Bug fixes in statistics handling
@ 2010-07-21 15:58 Vladislav Zolotarov
2010-07-21 18:12 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Vladislav Zolotarov @ 2010-07-21 15:58 UTC (permalink / raw)
To: Dave Miller; +Cc: netdev list, Eilon Greenstein, dmitry
Dave, pls., consider applying the following patches to the net-2.6 tree.
They include 2 bugs fixes in the statistics handling flow:
1) Protect the statistics state machine state update with a spinlock.
Otherwise there was a race condition that would cause the statistics
stay enabled despite they were disabled in the LINK_DOWN event handler.
2) Protect statistics ramrod sending code and a statistics counter
update with a spin lock. Otherwise there was a race condition that would
allow sending a statistics ramrods with the same sequence number or with
sequence numbers not in a natural order, which would cause a FW assert.
Thanks,
vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3 net-2.6] bnx2x: Bug fixes in statistics handling
2010-07-21 15:58 [PATCH 0/3 net-2.6] bnx2x: Bug fixes in statistics handling Vladislav Zolotarov
@ 2010-07-21 18:12 ` David Miller
2010-07-22 6:35 ` Vladislav Zolotarov
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-07-21 18:12 UTC (permalink / raw)
To: vladz; +Cc: netdev, eilong, dmitry
From: "Vladislav Zolotarov" <vladz@broadcom.com>
Date: Wed, 21 Jul 2010 18:58:55 +0300
> Dave, pls., consider applying the following patches to the net-2.6 tree.
> They include 2 bugs fixes in the statistics handling flow:
All applied.
There is a space character at the beginning of every "Signed-off-by:"
line in your patch postings, please get rid of them for future
submissions.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 0/3 net-2.6] bnx2x: Bug fixes in statistics handling
2010-07-21 18:12 ` David Miller
@ 2010-07-22 6:35 ` Vladislav Zolotarov
0 siblings, 0 replies; 3+ messages in thread
From: Vladislav Zolotarov @ 2010-07-22 6:35 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org, Eilon Greenstein, Dmitry Kravkov
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, July 21, 2010 9:13 PM
> To: Vladislav Zolotarov
> Cc: netdev@vger.kernel.org; Eilon Greenstein; Dmitry Kravkov
> Subject: Re: [PATCH 0/3 net-2.6] bnx2x: Bug fixes in statistics
> handling
>
> From: "Vladislav Zolotarov" <vladz@broadcom.com>
> Date: Wed, 21 Jul 2010 18:58:55 +0300
>
> > Dave, pls., consider applying the following patches to the net-2.6
> tree.
> > They include 2 bugs fixes in the statistics handling flow:
>
> All applied.
Thanks.
>
> There is a space character at the beginning of every "Signed-off-by:"
> line in your patch postings, please get rid of them for future
> submissions.
Hmmm... No prob., will do. My git creates it this way for some reason.
Probably some configuration glitch.
Thanks again,
vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-22 6:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-21 15:58 [PATCH 0/3 net-2.6] bnx2x: Bug fixes in statistics handling Vladislav Zolotarov
2010-07-21 18:12 ` David Miller
2010-07-22 6:35 ` Vladislav Zolotarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).