From: David Miller <davem@davemloft.net>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, julia@diku.dk, shemminger@vyatta.com
Subject: Re: [patch 2/3] arch/um/drivers: remove duplicate structure field initialization
Date: Wed, 21 Jul 2010 11:17:37 -0700 (PDT) [thread overview]
Message-ID: <20100721.111737.158419467.davem@davemloft.net> (raw)
In-Reply-To: <201007202225.o6KMPHA3021446@imap1.linux-foundation.org>
From: akpm@linux-foundation.org
Date: Tue, 20 Jul 2010 15:25:17 -0700
> From: Julia Lawall <julia@diku.dk>
>
> There are two initializations of ndo_set_mac_address, one to a local
> function that is not used otherwise and one to a function that is defined
> elsewhere.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
>
> akpm:
>
> - Use the standard eth_mac_addr() in uml_net_set_mac()
>
> - Remove unneeded and racy local set_ether_mac()
>
> - Remove duplicated (and incorrect)
> uml_netdev_ops.ndo_set_mac_address initializer.
>
> Fixes 8bb95b39a16ed55226810596f92216c53329d2fe ("uml: convert network
> device to netdevice ops").
>
> [akpm@linux-foundation.org: rework as above]
> Signed-off-by: Julia Lawall <julia@diku.dk>
> Cc: Stephen Hemminger <shemminger@vyatta.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Applied.
prev parent reply other threads:[~2010-07-21 18:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 22:25 [patch 2/3] arch/um/drivers: remove duplicate structure field initialization akpm
2010-07-21 18:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721.111737.158419467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=julia@diku.dk \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).