* [patch 3/3] drivers/net/82596.c: fix warning
@ 2010-07-20 22:25 akpm
2010-07-21 18:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2010-07-20 22:25 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, segooon
From: Andrew Morton <akpm@linux-foundation.org>
drivers/net/82596.c: In function 'i596_open':
drivers/net/82596.c:1044: warning: label 'err_irq_dev' defined but not used
Caused by "82596: free resources on error"
Cc: Kulikov Vasiliy <segooon@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/82596.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/82596.c~drivers-net-82596c-fix-warning drivers/net/82596.c
--- a/drivers/net/82596.c~drivers-net-82596c-fix-warning
+++ a/drivers/net/82596.c
@@ -1040,8 +1040,8 @@ err_queue:
err_irq_56:
#ifdef ENABLE_MVME16x_NET
free_irq(0x56, dev);
-#endif
err_irq_dev:
+#endif
free_irq(dev->irq, dev);
return res;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 3/3] drivers/net/82596.c: fix warning
2010-07-20 22:25 [patch 3/3] drivers/net/82596.c: fix warning akpm
@ 2010-07-21 18:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-07-21 18:18 UTC (permalink / raw)
To: akpm; +Cc: netdev, segooon
From: akpm@linux-foundation.org
Date: Tue, 20 Jul 2010 15:25:18 -0700
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/net/82596.c: In function 'i596_open':
> drivers/net/82596.c:1044: warning: label 'err_irq_dev' defined but not used
>
> Caused by "82596: free resources on error"
>
> Cc: Kulikov Vasiliy <segooon@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
When this hit the -mm tree, I replied to the -mm postinging that I applied
it to net-next-2.6
So it's integrated already :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-21 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-20 22:25 [patch 3/3] drivers/net/82596.c: fix warning akpm
2010-07-21 18:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).