From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: mirred, redirect action vs. dev refcount issue
Date: Wed, 21 Jul 2010 16:52:47 -0700 [thread overview]
Message-ID: <20100721165247.6d1dd879@nehalam> (raw)
In-Reply-To: <20100721.163955.12041610.davem@davemloft.net>
On Wed, 21 Jul 2010 16:39:55 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Wed, 21 Jul 2010 16:24:26 -0700
>
> > Alternatively, the mirror/redirect could just use ifindex which is
> > a soft reference, so if device is removed, they just drop.
> >
> > Lazy me favors the later.
>
> If it is the action rule holding onto the device, it should have
> an appropriate netdevice notifier handler.
There is no notifier there, and the module doesn't keep track of
list of filters. So that is why it has to be done at act api level.
> If it's a transient reference on receive, it should be transient
> and released eventually.
Kernel doesn't keep transient reference on receive any more.
next prev parent reply other threads:[~2010-07-21 23:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 23:24 mirred, redirect action vs. dev refcount issue Stephen Hemminger
2010-07-21 23:39 ` David Miller
2010-07-21 23:52 ` Stephen Hemminger [this message]
2010-07-21 23:58 ` David Miller
2010-07-22 0:00 ` Stephen Hemminger
2010-07-22 10:11 ` jamal
2010-07-22 17:42 ` Stephen Hemminger
2010-07-22 18:02 ` jamal
2010-07-23 4:45 ` [PATCH] net sched: fix race in mirred device removal Stephen Hemminger
2010-07-25 4:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721165247.6d1dd879@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).