From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: netdev@vger.kernel.org, mchan@broadcom.com
Subject: Re: [PATCH net-next-2.6 2/2] bonding: don't lock when copying/clearing VLAN list on slave
Date: Thu, 22 Jul 2010 14:13:05 -0700 (PDT) [thread overview]
Message-ID: <20100722.141305.04664571.davem@davemloft.net> (raw)
In-Reply-To: <1279750488-32611-2-git-send-email-fubar@us.ibm.com>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Wed, 21 Jul 2010 15:14:48 -0700
> When copying VLAN information to or removing from a slave
> during slave addition or removal, the bonding code currently holds
> the bond->lock for write to prevent concurrent modification of the
> vlan_list / vlgrp.
>
> This is unnecessary, as all of these operations occur under
> RTNL. Holding the bond->lock also caused might_sleep issues for
> some drivers' ndo_vlan_* functions. This patch removes the extra
> locking.
>
> Problem reported by Michael Chan <mchan@broadcom.com>
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied.
next prev parent reply other threads:[~2010-07-22 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 22:14 [PATCH net-next-2.6 1/2] bonding: change test for presence of VLANs Jay Vosburgh
2010-07-21 22:14 ` [PATCH net-next-2.6 2/2] bonding: don't lock when copying/clearing VLAN list on slave Jay Vosburgh
2010-07-22 21:13 ` David Miller [this message]
2010-07-22 21:12 ` [PATCH net-next-2.6 1/2] bonding: change test for presence of VLANs David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722.141305.04664571.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).