netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, netfilter@vger.kernel.org,
	netfilter-devel@vger.kernel.org,
	Malcolm Turnbull <malcolm@loadbalancer.org>,
	Wensong Zhang <wensong@linux-vs.org>,
	Julius Volz <julius.volz@gmail.com>,
	Patrick McHardy <kaber@trash.net>,
	"David S. Miller" <davem@davemloft.net>,
	Hannes Eder <heder@google.com>
Subject: Re: [patch v2.6 4/4] libxt_ipvs: user-space lib for netfilter matcher xt_ipvs
Date: Thu, 22 Jul 2010 15:57:55 +0900	[thread overview]
Message-ID: <20100722065751.GA17499@verge.net.au> (raw)
In-Reply-To: <alpine.LSU.2.01.1007220823340.4980@obet.zrqbmnf.qr>

On Thu, Jul 22, 2010 at 08:25:01AM +0200, Jan Engelhardt wrote:
> 
> On Thursday 2010-07-22 03:38, Simon Horman wrote:
> >
> >I must confess that I'm not familiar with using enum in this way.
> >Can I confirm that you are suggesting the following?
> >
> >enum {
> >	XT_IPVS_IPVS_PROPERTY =	1 << 0, /* all other options imply this one */
> >	XT_IPVS_PROTO =		1 << 1,
> >	XT_IPVS_VADDR =		1 << 2,
> >	XT_IPVS_VPORT =		1 << 3,
> >	XT_IPVS_DIR =		1 << 4,
> >	XT_IPVS_METHOD =	1 << 5,
> >	XT_IPVS_VPORTCTL =	1 << 6,
> >	XT_IPVS_MASK =		(1 << 7) - 1,
> >	XT_IPVS_ONCE_MASK =	(XT_IPVS_MASK & ~XT_IPVS_IPVS_PROPERTY)
> >};
> 
> Yes; You may drop the () in ONCE_MASK though.

Thanks; and yes, silliness on my part.

      reply	other threads:[~2010-07-22  6:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-11  9:03 [patch v2.6 0/4] IPVS full NAT support + netfilter 'ipvs' match support horms, Simon Horman
2010-07-11  9:03 ` [patch v2.6 1/4] netfilter: xt_ipvs (netfilter matcher for IPVS) horms, Simon Horman
2010-07-11  9:03 ` [patch v2.6 2/4] IPVS: make friends with nf_conntrack horms, Simon Horman
2010-07-11  9:03 ` [patch v2.6 3/4] IPVS: make FTP work with full NAT support horms, Simon Horman
2010-07-11  9:03 ` [patch v2.6 4/4] libxt_ipvs: user-space lib for netfilter matcher xt_ipvs horms, Simon Horman
2010-07-21  1:21   ` Simon Horman
2010-07-21  1:23     ` [patch v2.7 " Simon Horman
2010-07-21  6:35     ` [patch v2.6 " Jan Engelhardt
2010-07-21 13:21       ` Simon Horman
2010-07-21 13:28         ` Jan Engelhardt
2010-07-21 13:41           ` Simon Horman
2010-07-22  1:38             ` Simon Horman
2010-07-22  6:25               ` Jan Engelhardt
2010-07-22  6:57                 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100722065751.GA17499@verge.net.au \
    --to=horms@verge.net.au \
    --cc=davem@davemloft.net \
    --cc=heder@google.com \
    --cc=jengelh@medozas.de \
    --cc=julius.volz@gmail.com \
    --cc=kaber@trash.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=malcolm@loadbalancer.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).