* [PATCH net-next 5/7] be2net: supress printing error when mac query fails for VF
@ 2010-07-23 12:00 Ajit Khaparde
2010-07-23 19:38 ` David Miller
2010-07-23 19:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ajit Khaparde @ 2010-07-23 12:00 UTC (permalink / raw)
To: David Miller; +Cc: netdev
When a virtual function driver in initialized, the network mac
query command can fail. Skip display of error message in that case.
Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
---
drivers/net/benet/be_cmds.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 32ae324..cf3af05 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -76,7 +76,8 @@ static int be_mcc_compl_process(struct be_adapter *adapter,
sizeof(resp->hw_stats));
netdev_stats_update(adapter);
}
- } else if (compl_status != MCC_STATUS_NOT_SUPPORTED) {
+ } else if ((compl_status != MCC_STATUS_NOT_SUPPORTED) &&
+ (compl->tag0 != OPCODE_COMMON_NTWK_MAC_QUERY)) {
extd_status = (compl->status >> CQE_STATUS_EXTD_SHIFT) &
CQE_STATUS_EXTD_MASK;
dev_warn(&adapter->pdev->dev,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 5/7] be2net: supress printing error when mac query fails for VF
2010-07-23 12:00 [PATCH net-next 5/7] be2net: supress printing error when mac query fails for VF Ajit Khaparde
@ 2010-07-23 19:38 ` David Miller
2010-07-23 19:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-07-23 19:38 UTC (permalink / raw)
To: ajitk; +Cc: netdev
From: Ajit Khaparde <ajitk@serverengines.com>
Date: Fri, 23 Jul 2010 17:30:24 +0530
> - } else if (compl_status != MCC_STATUS_NOT_SUPPORTED) {
> + } else if ((compl_status != MCC_STATUS_NOT_SUPPORTED) &&
> + (compl->tag0 != OPCODE_COMMON_NTWK_MAC_QUERY)) {
I'll fix up this formatting when applying this patch but please be mindful
of this in the future, it should look like:
} else if ((compl_status != MCC_STATUS_NOT_SUPPORTED) &&
(compl->tag0 != OPCODE_COMMON_NTWK_MAC_QUERY)) {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next 5/7] be2net: supress printing error when mac query fails for VF
2010-07-23 12:00 [PATCH net-next 5/7] be2net: supress printing error when mac query fails for VF Ajit Khaparde
2010-07-23 19:38 ` David Miller
@ 2010-07-23 19:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-07-23 19:44 UTC (permalink / raw)
To: ajitk; +Cc: netdev
From: Ajit Khaparde <ajitk@serverengines.com>
Date: Fri, 23 Jul 2010 17:30:24 +0530
> When a virtual function driver in initialized, the network mac
> query command can fail. Skip display of error message in that case.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-23 19:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-23 12:00 [PATCH net-next 5/7] be2net: supress printing error when mac query fails for VF Ajit Khaparde
2010-07-23 19:38 ` David Miller
2010-07-23 19:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).