[PATCH] iproute2: use int instead of long for RTAX_HOPLIMIT compare

[PATCH] iproute2: use int instead of long for RTAX_HOPLIMIT compare

[Ulrich Weber]

otherwise "if ((int)val == -1)" will never match on 64 bit systems

Signed-off-by: Ulrich Weber <uweber@astaro.com>
---
 ip/iproute.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ip/iproute.c b/ip/iproute.c
index 04b253a..711576e 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -494,7 +494,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
 			val = *(unsigned*)RTA_DATA(mxrta[i]);
 			switch (i) {
 			case RTAX_HOPLIMIT:
-				if ((long)val == -1)
+				if ((int)val == -1)
 					val = 0;
 				/* fall through */
 			default:
-- 
1.7.0.4

Re: [PATCH] iproute2: use int instead of long for RTAX_HOPLIMIT compare

[Stephen Hemminger]

On Fri, 23 Jul 2010 15:39:10 +0200
Ulrich Weber <uweber@astaro.com> wrote:

> otherwise "if ((int)val == -1)" will never match on 64 bit systems
> 
> Signed-off-by: Ulrich Weber <uweber@astaro.com>
> ---
>  ip/iproute.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ip/iproute.c b/ip/iproute.c
> index 04b253a..711576e 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -494,7 +494,7 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>  			val = *(unsigned*)RTA_DATA(mxrta[i]);
>  			switch (i) {
>  			case RTAX_HOPLIMIT:
> -				if ((long)val == -1)
> +				if ((int)val == -1)
>  					val = 0;
>  				/* fall through */
>  			default:

All applied

-- 

Re: [PATCH] iproute2: use int instead of long for RTAX_HOPLIMIT compare

[David Miller]

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 23 Jul 2010 09:01:39 -0700

> All applied

Please update patchwork, and in the future please do so before emailing
the submitter that the patch is applied.

Patches assigned to you tend to just pile up, defeating the whole purpose
of using patchwork.

If you really don't want to stay on top of this and actually use the
tool, just let me know and I'll just toss all the patches that come
into the netdev group for iproute2.

This is about the 4th or 5th time I've brought this issue up with you.

I know you might find this hard to believe, but it will be less work
for you if the first thing you do as iproute2 maintainer every day is
open up the patchwork web page and scan the incoming patches and
process them, instead of hitting them via the mailing list first. :-)