From: Dan Carpenter <error27@gmail.com>
To: walter harms <wharms@bfs.de>
Cc: Joe Perches <joe@perches.com>,
Lennert Buytenhek <buytenh@wantstofly.org>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>,
Denis Kirjanov <kirjanov@gmail.com>,
Saeed Bishara <saeed@marvell.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next v2] mv643xx_eth: potential null dereference
Date: Sat, 24 Jul 2010 00:15:14 +0200 [thread overview]
Message-ID: <20100723221514.GJ26313@bicker> (raw)
In-Reply-To: <4C49C39E.8020502@bfs.de>
On Fri, Jul 23, 2010 at 06:30:22PM +0200, walter harms wrote:
> this is a bit complicated, IMHO ppl have a bigger chance to discover what is going on
> with this version:
>
> if (!pd ) {
> msp->t_clk = 133000000;
> msp->tx_csum_limit = 9 * 1024;
> }
> else
> {
> msp->t_clk = pd->t_clk ? pd->t_clk : 133000000 ;
> msp->tx_csum_limit = pd->tx_csum_limit ? pd->tx_csum_limit : 9 * 1024;
> }
>
But then instead of 2 magic numbers we would have 4. :/
regards,
dan carpenter
next prev parent reply other threads:[~2010-07-23 22:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 10:15 [patch -next] mv643xx_eth: potential null dereference Dan Carpenter
2010-07-23 10:32 ` Joe Perches
2010-07-23 11:05 ` [patch -next v2] " Dan Carpenter
2010-07-23 11:18 ` Lennert Buytenhek
2010-07-23 20:05 ` David Miller
2010-07-23 16:30 ` walter harms
2010-07-23 22:15 ` Dan Carpenter [this message]
2010-07-24 8:59 ` walter harms
2010-07-24 19:00 ` Lennert Buytenhek
2010-07-25 14:47 ` walter harms
2010-07-25 15:54 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100723221514.GJ26313@bicker \
--to=error27@gmail.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@marvell.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).