From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: hadi@cyberus.ca, netdev@vger.kernel.org
Subject: Re: [PATCH] net sched: fix race in mirred device removal
Date: Sat, 24 Jul 2010 21:04:46 -0700 (PDT) [thread overview]
Message-ID: <20100724.210446.115927978.davem@davemloft.net> (raw)
In-Reply-To: <20100722214504.42e0e7de@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 22 Jul 2010 21:45:04 -0700
> This fixes hang when target device of mirred packet classifier
> action is removed.
>
> If a mirror or redirection action is configured to cause packets
> to go to another device, the classifier holds a ref count, but was assuming
> the adminstrator cleaned up all redirections before removing. The fix
> is to add a notifier and cleanup during unregister.
>
> The new list is implicitly protected by RTNL mutex because
> it is held during filter add/delete as well as notifier.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Applied to net-2.6, thanks.
prev parent reply other threads:[~2010-07-25 4:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 23:24 mirred, redirect action vs. dev refcount issue Stephen Hemminger
2010-07-21 23:39 ` David Miller
2010-07-21 23:52 ` Stephen Hemminger
2010-07-21 23:58 ` David Miller
2010-07-22 0:00 ` Stephen Hemminger
2010-07-22 10:11 ` jamal
2010-07-22 17:42 ` Stephen Hemminger
2010-07-22 18:02 ` jamal
2010-07-23 4:45 ` [PATCH] net sched: fix race in mirred device removal Stephen Hemminger
2010-07-25 4:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100724.210446.115927978.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).