From: Lennert Buytenhek <buytenh@wantstofly.org>
To: walter harms <wharms@bfs.de>
Cc: Dan Carpenter <error27@gmail.com>, Joe Perches <joe@perches.com>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>,
Denis Kirjanov <kirjanov@gmail.com>,
Saeed Bishara <saeed@marvell.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch -next v2] mv643xx_eth: potential null dereference
Date: Sat, 24 Jul 2010 21:00:36 +0200 [thread overview]
Message-ID: <20100724190036.GA21121@mail.wantstofly.org> (raw)
In-Reply-To: <4C4AAB5B.2050901@bfs.de>
On Sat, Jul 24, 2010 at 10:59:07AM +0200, walter harms wrote:
> IMHO it would be better to make sure that pd->t_clk,pd->tx_csum_limit
> have usefull values than adding a check but this is up to the maintainer.
I don't see the point of that at all. We check against zero to see
whether the caller bothered to fill in the field at all, but if the
caller wants to pass in bogus values, that's up to the caller.
next prev parent reply other threads:[~2010-07-24 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 10:15 [patch -next] mv643xx_eth: potential null dereference Dan Carpenter
2010-07-23 10:32 ` Joe Perches
2010-07-23 11:05 ` [patch -next v2] " Dan Carpenter
2010-07-23 11:18 ` Lennert Buytenhek
2010-07-23 20:05 ` David Miller
2010-07-23 16:30 ` walter harms
2010-07-23 22:15 ` Dan Carpenter
2010-07-24 8:59 ` walter harms
2010-07-24 19:00 ` Lennert Buytenhek [this message]
2010-07-25 14:47 ` walter harms
2010-07-25 15:54 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100724190036.GA21121@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=joe@perches.com \
--cc=jpirko@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@marvell.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).