From: David Miller <davem@davemloft.net>
To: bhavesh@vmware.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.35-rc1] net-next: Fix an overflow bug in vmxnet3 Tx descriptor
Date: Sun, 25 Jul 2010 17:06:11 -0700 (PDT) [thread overview]
Message-ID: <20100725.170611.71132252.davem@davemloft.net> (raw)
In-Reply-To: <20100725004329.GB6680@bhavesh-lx1.eng.vmware.com>
From: Bhavesh Davda <bhavesh@vmware.com>
Date: Sat, 24 Jul 2010 17:43:29 -0700
> ---
If you put the "---" there are the beginning of your message,
the whole commit message is discarded by GIT.
I said you should put "---" at the end of the commit message,
when you want to add more side commentary that should not appear
in the commit message but is for people in this thread to read.
I fixed this up when adding your patch, but I have no idea why
you did this. Please don't do it again.
> Fix an overflow bug in vmxnet3 Tx descriptor
>
> This patch fixes a bug where a 16K buffer on a Tx descriptor was overflowing
> into the 'gen' bit in the descriptor thereby corrupting the descriptor and
> stalling the transmit ring.
>
> Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
> Signed-off-by: Shreyas Bhatewara <sbhatewara@vmware.com>
> Signed-off-by: Matthew Delco <delcoM@vmware.com>
> Signed-off-by: Ronghua Zhang <ronghua@vmware.com>
Applied, thanks.
next prev parent reply other threads:[~2010-07-26 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 0:43 [PATCH 2.6.35-rc1] net-next: Fix an overflow bug in vmxnet3 Tx descriptor Bhavesh Davda
2010-07-26 0:06 ` David Miller [this message]
2010-07-26 12:10 ` Bhavesh Davda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100725.170611.71132252.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhavesh@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).