From: David Miller <davem@davemloft.net>
To: mditto@google.com
Cc: netdev@vger.kernel.org, adobriyan@gmail.com,
shemminger@vyatta.com, ben@decadent.org.uk, stas@lvk.cs.msu.su,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] forcedeth: Fix different hardware statistics versions.
Date: Sun, 25 Jul 2010 21:54:38 -0700 (PDT) [thread overview]
Message-ID: <20100725.215438.189694767.davem@davemloft.net> (raw)
In-Reply-To: <20100722220252.E46C7182B00@starthinker.mtv.corp.google.com>
From: mditto@google.com (Mike Ditto)
Date: Thu, 22 Jul 2010 15:02:52 -0700 (PDT)
> The macros for the values of the bit field describing the four
> different versions of statistics supported by different hardware
> variants were being misused. Where the code was trying to test if the
> hardware implements V3, it was actually testing whether it implements
> any of V1, V2, or V3, causing the driver to report statistics that
> don't really exist in the hardware, with bogus values.
>
> Signed-off-by: Mike Ditto <mditto@google.com>
Applied to net-next-2.6, thanks.
prev parent reply other threads:[~2010-07-26 4:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 22:02 [PATCH] forcedeth: Fix different hardware statistics versions Mike Ditto
2010-07-26 4:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100725.215438.189694767.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mditto@google.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stas@lvk.cs.msu.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).