From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: ron.mercer@qlogic.com, linux-driver@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] drivers/net/qla3xxx.c: Checkpatch cleanups
Date: Sun, 25 Jul 2010 22:03:48 -0700 (PDT) [thread overview]
Message-ID: <20100725.220348.48497105.davem@davemloft.net> (raw)
In-Reply-To: <118c687d97762e235ba61733ef1610f6443ae1eb.1279848705.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Thu, 22 Jul 2010 18:36:17 -0700
> Remove typedefs
> Indentation and spacing
> Use a temporary for a very long pointer variable
> More 80 column compatible
> Convert a switch to if/else if
>
> Compile tested only, depends on patch "Update logging message style"
>
> (old)
> $ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
> total: 209 errors, 82 warnings, 3995 lines checked
>
> (new)
> $ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
> total: 2 errors, 0 warnings, 3970 lines checked
>
> $ size drivers/net/qla3xxx.o.*
> text data bss dec hex filename
> 50413 212 13864 64489 fbe9 drivers/net/qla3xxx.o.old
> 49959 212 13728 63899 f99b drivers/net/qla3xxx.o.new
>
> Signed-off-by: Joe Perches <joe@perches.com>
Also applied, thanks Joe.
prev parent reply other threads:[~2010-07-26 5:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 1:36 [PATCH net-next] drivers/net/qla3xxx.c: Checkpatch cleanups Joe Perches
2010-07-26 5:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100725.220348.48497105.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).