* [PATCH] usbnet: use jiffies in schedule_timeout(), not msecs
@ 2010-07-26 8:25 Kulikov Vasiliy
2010-07-27 4:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-26 8:25 UTC (permalink / raw)
To: kernel-janitors
Cc: David Brownell, Greg Kroah-Hartman, David S. Miller,
Ben Hutchings, Joe Perches, Stephen Hemminger, Jussi Kivilinna,
netdev, linux-usb, linux-kernel
usbnet_terminate_urbs() uses schedule_timeout() with argument 3 msecs.
schedule_timeout() uses jiffies as argument, so convert msecs to jiffies
with msecs_to_jiffies().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/net/usb/usbnet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 7eab407..b243386 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -624,7 +624,7 @@ static void usbnet_terminate_urbs(struct usbnet *dev)
while (!skb_queue_empty(&dev->rxq)
&& !skb_queue_empty(&dev->txq)
&& !skb_queue_empty(&dev->done)) {
- schedule_timeout(UNLINK_TIMEOUT_MS);
+ schedule_timeout(msecs_to_jiffies(UNLINK_TIMEOUT_MS));
set_current_state(TASK_UNINTERRUPTIBLE);
netif_dbg(dev, ifdown, dev->net,
"waited for %d urb completions\n", temp);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usbnet: use jiffies in schedule_timeout(), not msecs
2010-07-26 8:25 [PATCH] usbnet: use jiffies in schedule_timeout(), not msecs Kulikov Vasiliy
@ 2010-07-27 4:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-07-27 4:05 UTC (permalink / raw)
To: segooon
Cc: kernel-janitors, dbrownell, gregkh, ben, joe, shemminger,
jussi.kivilinna, netdev, linux-usb, linux-kernel
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 26 Jul 2010 12:25:42 +0400
> usbnet_terminate_urbs() uses schedule_timeout() with argument 3 msecs.
> schedule_timeout() uses jiffies as argument, so convert msecs to jiffies
> with msecs_to_jiffies().
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-27 4:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-26 8:25 [PATCH] usbnet: use jiffies in schedule_timeout(), not msecs Kulikov Vasiliy
2010-07-27 4:05 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).