* [PATCH] ip: correctly report 802.15.4 link type
@ 2010-06-25 14:01 Jan Engelhardt
0 siblings, 0 replies; 6+ messages in thread
From: Jan Engelhardt @ 2010-06-25 14:01 UTC (permalink / raw)
To: stephen.hemminger; +Cc: netdev
Up until now, the "hardwpan" devices were displayed as link/[804].
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
lib/ll_types.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib/ll_types.c b/lib/ll_types.c
index 846cdb0..1cc46b6 100644
--- a/lib/ll_types.c
+++ b/lib/ll_types.c
@@ -125,6 +125,9 @@ __PF(IEEE80211_PRISM,ieee802.11/prism)
#ifdef ARPHRD_IEEE80211_RADIOTAP
__PF(IEEE80211_RADIOTAP,ieee802.11/radiotap)
#endif
+#ifdef ARPHRD_IEEE802154
+__PF(IEEE802154, ieee802.15.4)
+#endif
#ifdef ARPHRD_NONE
__PF(NONE, none)
#endif
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ip: correctly report 802.15.4 link type
@ 2010-06-26 23:51 Stephen Hemminger
2010-06-27 7:01 ` Jan Engelhardt
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2010-06-26 23:51 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: netdev
OK but long-term fix is to get rid of hardcoded table
Jan Engelhardt <jengelh@medozas.de> wrote:
>Up until now, the "hardwpan" devices were displayed as link/[804].
>
>Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
>---
> lib/ll_types.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/lib/ll_types.c b/lib/ll_types.c
>index 846cdb0..1cc46b6 100644
>--- a/lib/ll_types.c
>+++ b/lib/ll_types.c
>@@ -125,6 +125,9 @@ __PF(IEEE80211_PRISM,ieee802.11/prism)
> #ifdef ARPHRD_IEEE80211_RADIOTAP
> __PF(IEEE80211_RADIOTAP,ieee802.11/radiotap)
> #endif
>+#ifdef ARPHRD_IEEE802154
>+__PF(IEEE802154, ieee802.15.4)
>+#endif
> #ifdef ARPHRD_NONE
> __PF(NONE, none)
> #endif
>--
>1.7.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ip: correctly report 802.15.4 link type
2010-06-26 23:51 Stephen Hemminger
@ 2010-06-27 7:01 ` Jan Engelhardt
0 siblings, 0 replies; 6+ messages in thread
From: Jan Engelhardt @ 2010-06-27 7:01 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On Sunday 2010-06-27 01:51, Stephen Hemminger wrote:
>OK but long-term fix is to get rid of hardcoded table
With what will you be replacing it?
>>Up until now, the "hardwpan" devices were displayed as link/[804].
>>
>>Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
>>---
>> lib/ll_types.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>>diff --git a/lib/ll_types.c b/lib/ll_types.c
>>index 846cdb0..1cc46b6 100644
>>--- a/lib/ll_types.c
>>+++ b/lib/ll_types.c
>>@@ -125,6 +125,9 @@ __PF(IEEE80211_PRISM,ieee802.11/prism)
>> #ifdef ARPHRD_IEEE80211_RADIOTAP
>> __PF(IEEE80211_RADIOTAP,ieee802.11/radiotap)
>> #endif
>>+#ifdef ARPHRD_IEEE802154
>>+__PF(IEEE802154, ieee802.15.4)
>>+#endif
>> #ifdef ARPHRD_NONE
>> __PF(NONE, none)
>> #endif
>>--
>>1.7.1
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* iproute2: 802.15.4 reporting
@ 2010-07-25 20:28 Jan Engelhardt
2010-07-25 20:28 ` [PATCH] ip: correctly report 802.15.4 link type Jan Engelhardt
0 siblings, 1 reply; 6+ messages in thread
From: Jan Engelhardt @ 2010-07-25 20:28 UTC (permalink / raw)
To: stephen.hemminger; +Cc: netdev
Hi,
I am resending this patch as it has not been included yet.
Last time you mentioned something about wanting to do this different,
but this is already your standard array of int-string mappings, not
much to improve there I'd say.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ip: correctly report 802.15.4 link type
2010-07-25 20:28 iproute2: 802.15.4 reporting Jan Engelhardt
@ 2010-07-25 20:28 ` Jan Engelhardt
2010-07-26 16:35 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Jan Engelhardt @ 2010-07-25 20:28 UTC (permalink / raw)
To: stephen.hemminger; +Cc: netdev
Up until now, the "hardwpan" devices were displayed as link/[804].
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
lib/ll_types.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/lib/ll_types.c b/lib/ll_types.c
index 846cdb0..1cc46b6 100644
--- a/lib/ll_types.c
+++ b/lib/ll_types.c
@@ -125,6 +125,9 @@ __PF(IEEE80211_PRISM,ieee802.11/prism)
#ifdef ARPHRD_IEEE80211_RADIOTAP
__PF(IEEE80211_RADIOTAP,ieee802.11/radiotap)
#endif
+#ifdef ARPHRD_IEEE802154
+__PF(IEEE802154, ieee802.15.4)
+#endif
#ifdef ARPHRD_NONE
__PF(NONE, none)
#endif
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ip: correctly report 802.15.4 link type
2010-07-25 20:28 ` [PATCH] ip: correctly report 802.15.4 link type Jan Engelhardt
@ 2010-07-26 16:35 ` Stephen Hemminger
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2010-07-26 16:35 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: stephen.hemminger, netdev
On Sun, 25 Jul 2010 22:28:02 +0200
Jan Engelhardt <jengelh@medozas.de> wrote:
> Up until now, the "hardwpan" devices were displayed as link/[804].
>
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
> ---
> lib/ll_types.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/ll_types.c b/lib/ll_types.c
> index 846cdb0..1cc46b6 100644
> --- a/lib/ll_types.c
> +++ b/lib/ll_types.c
> @@ -125,6 +125,9 @@ __PF(IEEE80211_PRISM,ieee802.11/prism)
> #ifdef ARPHRD_IEEE80211_RADIOTAP
> __PF(IEEE80211_RADIOTAP,ieee802.11/radiotap)
> #endif
> +#ifdef ARPHRD_IEEE802154
> +__PF(IEEE802154, ieee802.15.4)
> +#endif
> #ifdef ARPHRD_NONE
> __PF(NONE, none)
> #endif
Already fixed.
--
commit 4dbda0f482b8947d064b3f82992394033de6616c
Author: Stephen Hemminger <stephen.hemminger@vyatta.com>
Date: Fri Jul 23 13:12:12 2010 -0700
Update ARP header type table
Add all current values. Since if_arp.h is included, get rid
of ifdefs'. Make table constant.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-07-26 16:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-25 20:28 iproute2: 802.15.4 reporting Jan Engelhardt
2010-07-25 20:28 ` [PATCH] ip: correctly report 802.15.4 link type Jan Engelhardt
2010-07-26 16:35 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2010-06-26 23:51 Stephen Hemminger
2010-06-27 7:01 ` Jan Engelhardt
2010-06-25 14:01 Jan Engelhardt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).