From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next 2/3] stmmac: fix timer setup when use dual mac Kconfig
Date: Tue, 27 Jul 2010 20:45:28 -0700 (PDT) [thread overview]
Message-ID: <20100727.204528.149852941.davem@davemloft.net> (raw)
In-Reply-To: <1280225387-26240-2-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Tue, 27 Jul 2010 12:09:46 +0200
> The driver erroneously sets the tmrate to zero when the
> TMU initialisation fails. This actually generates problems
> while using the dual GMAC configuration.
>
> With this patch, enabling both the dual gmac and the timer
> optimisation, the first interface opened will use the tmu
> channel 2, the second one won't be able to use the timer but
> will continue to work without mitigating the interrupts by
> using the external timer (i.e. TMU channel 2).
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
This is not how we do things.
All of the options that influence the driver should be right next
to the main driver option.
What the platform SOC Kconfig's can do is 'select' those option.
But even better is to get rid of all of these feature Kconfig options,
and communicate the capability in the platform_device probe
information or similar.
next prev parent reply other threads:[~2010-07-28 3:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 10:09 [net-next 1/3] stmmac: remove the STMMAC_DUAL_MAC option Giuseppe CAVALLARO
2010-07-27 10:09 ` [net-next 2/3] stmmac: fix timer setup when use dual mac Kconfig Giuseppe CAVALLARO
2010-07-27 10:09 ` [net-next 3/3] stmmac: fix automatic PAD/FCS stripping Giuseppe CAVALLARO
2010-07-28 3:45 ` David Miller
2010-07-28 3:45 ` David Miller [this message]
2010-07-28 3:46 ` [net-next 2/3] stmmac: fix timer setup when use dual mac Kconfig David Miller
2010-07-28 3:45 ` David Miller
2010-07-28 6:55 ` [net-next 1/3] stmmac: remove the STMMAC_DUAL_MAC option Peppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727.204528.149852941.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).