From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next 3/3] stmmac: fix automatic PAD/FCS stripping
Date: Tue, 27 Jul 2010 20:45:45 -0700 (PDT) [thread overview]
Message-ID: <20100727.204545.55874058.davem@davemloft.net> (raw)
In-Reply-To: <1280225387-26240-3-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Tue, 27 Jul 2010 12:09:47 +0200
> For Simple Ethernet frames (802.2 and 802.3) the GMAC Core
> never strips pad and fcs. This means the ACS has no effect
> on IPv4/6 frames.
> The FL bits, in the RDES0, include the FCS so the driver
> has to remove it in SW.
> For 802.3 frame format with LLC or LLC-SNAP, when set the ACS
> bit, the HW strips both PAD and FCS.
> The FL bits, in the RDES0, actually represents the frame length
> already stripped.
> This patch fixes this logic within the device driver that
> erroneously removed 4byte from 802.3 frames already stripped
> corrupting the payload.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied.
next prev parent reply other threads:[~2010-07-28 3:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 10:09 [net-next 1/3] stmmac: remove the STMMAC_DUAL_MAC option Giuseppe CAVALLARO
2010-07-27 10:09 ` [net-next 2/3] stmmac: fix timer setup when use dual mac Kconfig Giuseppe CAVALLARO
2010-07-27 10:09 ` [net-next 3/3] stmmac: fix automatic PAD/FCS stripping Giuseppe CAVALLARO
2010-07-28 3:45 ` David Miller [this message]
2010-07-28 3:45 ` [net-next 2/3] stmmac: fix timer setup when use dual mac Kconfig David Miller
2010-07-28 3:46 ` David Miller
2010-07-28 3:45 ` David Miller
2010-07-28 6:55 ` [net-next 1/3] stmmac: remove the STMMAC_DUAL_MAC option Peppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727.204545.55874058.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).