From: David Miller <davem@davemloft.net>
To: dmitry@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net-next 0/8] bnx2x: move bnx2x to separate folder and divide to files
Date: Tue, 27 Jul 2010 20:56:40 -0700 (PDT) [thread overview]
Message-ID: <20100727.205640.235673886.davem@davemloft.net> (raw)
In-Reply-To: <20100727.203640.173839576.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 27 Jul 2010 20:36:40 -0700 (PDT)
> From: "Dmitry Kravkov" <dmitry@broadcom.com>
> Date: Wed, 28 Jul 2010 01:40:47 +0300
>
>> resubmit the series with fixes for git-apply. Thanks
>
> All applied, thanks.
Ummm, so what in the world did you think was going to happen
the next time I try to merge net-2.6 into net-next-2.6?
Any clue what might happen?
Any idea?
Since you not only moved the driver into a new directory,
but also moved functions all over the damn place into new
files too, the bnx2x bug fixes in net-2.6 have to be applied
by hand by me during the merge, bit by bit.
This is one of the millions of reasons I absolutely detest multi-file
drivers, people move crap around, patches from one tree can't easily
be munged into another, etc.
If it's too big to fit in one file, your driver is too damn bloated.
End of story. Put the thing into one file under drivers/net and
simplify _everyones_ life.
I'm fixing this merge mess up, but I'm very not happy about how
you guys staged this sequence of events.
prev parent reply other threads:[~2010-07-28 3:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 22:40 [PATCH net-next 0/8] bnx2x: move bnx2x to separate folder and divide to files Dmitry Kravkov
2010-07-28 3:36 ` David Miller
2010-07-28 3:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727.205640.235673886.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).