From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: johannes@sipsolutions.net, paulmck@linux.vnet.ibm.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: add rcu_read_lock
Date: Wed, 28 Jul 2010 10:52:09 -0700 (PDT) [thread overview]
Message-ID: <20100728.105209.25114107.davem@davemloft.net> (raw)
In-Reply-To: <20100728095730.11450561@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 28 Jul 2010 09:57:30 -0700
> Long ago, when bridge was converted to RCU, rcu lock was equivalent
> to having preempt disabled. RCU has changed a lot since then and
> bridge code was still assuming the since transmit was called with
> bottom half disabled, it was RCU safe.
>
> In addition to fixing the code, update the comments about
> locking to match current state as well.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
As I stated in another email I added the original commit.
This version still didn't apply to net-2.6 and also you failed
to add a tested-by tag for Johannes to the commit message, which
I also did alongside backporting the original patch to net-2.6
next prev parent reply other threads:[~2010-07-28 17:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 10:45 br_forward.c - rcu dereference warning Johannes Berg
2010-07-27 12:38 ` Paul E. McKenney
2010-07-27 18:26 ` Stephen Hemminger
2010-07-27 20:14 ` Johannes Berg
2010-07-27 20:42 ` Stephen Hemminger
2010-07-28 6:48 ` Johannes Berg
2010-07-28 7:33 ` Johannes Berg
2010-07-28 16:57 ` [PATCH] bridge: add rcu_read_lock Stephen Hemminger
2010-07-28 17:52 ` David Miller [this message]
2010-07-28 18:01 ` Stephen Hemminger
2010-07-28 17:39 ` br_forward.c - rcu dereference warning David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100728.105209.25114107.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).