* [PATCH -next] net: ks8842 depends on DMA_ENGINE
[not found] <20100729143211.9e7edaed.sfr@canb.auug.org.au>
@ 2010-07-29 17:14 ` Randy Dunlap
2010-07-31 5:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-07-29 17:14 UTC (permalink / raw)
To: Stephen Rothwell, davem; +Cc: linux-next, LKML, netdev
From: Randy Dunlap <randy.dunlap@oracle.com>
ks8842 uses dma channel functions, so it should depend on DMA_ENGINE.
ERROR: "__dma_request_channel" [drivers/net/ks8842.ko] undefined!
ERROR: "dma_release_channel" [drivers/net/ks8842.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20100729.orig/drivers/net/Kconfig
+++ linux-next-20100729/drivers/net/Kconfig
@@ -1751,7 +1751,7 @@ config TLAN
config KS8842
tristate "Micrel KSZ8841/42 with generic bus interface"
- depends on HAS_IOMEM
+ depends on HAS_IOMEM && DMA_ENGINE
help
This platform driver is for KSZ8841(1-port) / KS8842(2-port)
ethernet switch chip (managed, VLAN, QoS) from Micrel or
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: ks8842 depends on DMA_ENGINE
2010-07-29 17:14 ` [PATCH -next] net: ks8842 depends on DMA_ENGINE Randy Dunlap
@ 2010-07-31 5:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-07-31 5:10 UTC (permalink / raw)
To: randy.dunlap; +Cc: sfr, linux-next, linux-kernel, netdev
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 29 Jul 2010 10:14:27 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> ks8842 uses dma channel functions, so it should depend on DMA_ENGINE.
>
> ERROR: "__dma_request_channel" [drivers/net/ks8842.ko] undefined!
> ERROR: "dma_release_channel" [drivers/net/ks8842.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-31 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100729143211.9e7edaed.sfr@canb.auug.org.au>
2010-07-29 17:14 ` [PATCH -next] net: ks8842 depends on DMA_ENGINE Randy Dunlap
2010-07-31 5:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).