netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: henrique.camargo@ensitec.com.br
Cc: chaithrika@ti.com, srk@ti.com, khilman@deeprootsystems.com,
	jpirko@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, segooon@gmail.com
Subject: Re: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.
Date: Fri, 30 Jul 2010 22:20:34 -0700 (PDT)	[thread overview]
Message-ID: <20100730.222034.183058824.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTiko540hMAUhaJr5mNKzFK2-vBOTZmEOxZWZv7ci@mail.gmail.com>

From: Henrique Camargo <henrique.camargo@ensitec.com.br>
Date: Thu, 29 Jul 2010 12:51:49 -0300

> From: Henrique Camargo

>From lines need valid email addresses.  But in this case since you
are the person who wrote the patch, adding another From: tag in
the message body is superfluous and you can just omit it.

> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 25e14d2..b89b7bf 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
>         struct net_device *ndev = priv->ndev;
>         u32 cnt;
> 
> -       if (unlikely(num_tokens && netif_queue_stopped(dev)))
> -               netif_start_queue(dev);
> +       if (unlikely(num_tokens && netif_queue_stopped(ndev)))
> +               netif_start_queue(ndev);

Your patch is corrupted, tab characters have been turned into spaces by
your email client.

This makes your patch unusable.

Please fix up these errors and resubmit your patch.

Thank you.

  parent reply	other threads:[~2010-07-31  5:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29 15:51 [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros Henrique Camargo
2010-07-29 16:03 ` Vasiliy Kulikov
2010-07-31  5:20 ` David Miller [this message]
2010-08-03  3:10   ` [PATCH] Fixes a typo from "dev" to "ndev" Henrique Camargo
2010-08-03  5:03     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100730.222034.183058824.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chaithrika@ti.com \
    --cc=henrique.camargo@ensitec.com.br \
    --cc=jpirko@redhat.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=segooon@gmail.com \
    --cc=srk@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).