From: David Miller <davem@davemloft.net>
To: dp@highloadlab.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, kaber@trash.net,
pekkas@netcore.fi, yoshfuji@linux-ipv6.org,
eric.dumazet@gmail.com, ilpo.jarvinen@helsinki.fi,
akpm@linux-foundation.org, steve@digidescorp.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
william.allen.simpson@gmail.com
Subject: Re: [PATCH] tcp: cookie transactions setsockopt memory leak
Date: Fri, 30 Jul 2010 23:05:24 -0700 (PDT) [thread overview]
Message-ID: <20100730.230524.39186905.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTinHWJviHmhVcFQkobsgxa4-AaFUpHmd1wybiB+u@mail.gmail.com>
From: Dmitry Popov <dp@highloadlab.com>
Date: Thu, 29 Jul 2010 15:59:36 +0400
> From: Dmitry Popov <dp@highloadlab.com>
>
> There is a bug in do_tcp_setsockopt(net/ipv4/tcp.c),
> TCP_COOKIE_TRANSACTIONS case.
> In some cases (when tp->cookie_values == NULL) new tcp_cookie_values
> structure can be allocated (at cvp), but not bound to
> tp->cookie_values. So a memory leak occurs.
>
> Signed-off-by: Dmitry Popov <dp@highloadlab.com>
Applied and queued up for -stable, thanks Dmitry.
prev parent reply other threads:[~2010-07-31 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 11:59 [PATCH] tcp: cookie transactions setsockopt memory leak Dmitry Popov
2010-07-31 6:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730.230524.39186905.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dp@highloadlab.com \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=steve@digidescorp.com \
--cc=william.allen.simpson@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).