From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: andy@greyhouse.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bonding: take rtnl in bond_loadbalance_arp_mon
Date: Fri, 30 Jul 2010 23:28:48 -0700 (PDT) [thread overview]
Message-ID: <20100730.232848.115930956.davem@davemloft.net> (raw)
In-Reply-To: <23558.1280425791@death>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Thu, 29 Jul 2010 10:49:51 -0700
> Andy Gospodarek <andy@greyhouse.net> wrote:
>
>>[PATCH net-next] bonding: prevent sysfs from allowing arp monitoring with alb/tlb
>>
>>When using module options arp monitoring and balance-alb/balance-tlb
>>are mutually exclusive options. Anytime balance-alb/balance-tlb are
>>enabled mii monitoring is forced to 100ms if not set. When configuring
>>via sysfs no checking is currently done.
>>
>>Handling these cases with sysfs has to be done a bit differently because
>>we do not have all configuration information available at once. This
>>patch will not allow a mode change to balance-alb/balance-tlb if
>>arp_interval is already non-zero. It will also not allow the user to
>>set a non-zero arp_interval value if the mode is already set to
>>balance-alb/balance-tlb. They are still mutually exclusive on a
>>first-come, first serve basis.
>>
>>Tested with initscripts on Fedora and manual setting via sysfs.
>>
>>Signed-off-by: Andy Gospodarek <gospo@redhat.com>
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied, thanks guys.
prev parent reply other threads:[~2010-07-31 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 21:04 [PATCH net-next] bonding: take rtnl in bond_loadbalance_arp_mon Andy Gospodarek
2010-07-28 21:39 ` Jay Vosburgh
2010-07-29 1:13 ` Andy Gospodarek
2010-07-29 17:49 ` Jay Vosburgh
2010-07-31 6:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730.232848.115930956.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).