From: Herbert Xu <herbert@gondor.apana.org.au>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <hadi@cyberus.ca>,
netdev@vger.kernel.org
Subject: Re: [PATCH] act_nat: get the position info from skb->tc_verd
Date: Fri, 30 Jul 2010 10:36:49 +0800 [thread overview]
Message-ID: <20100730023649.GA5798@gondor.apana.org.au> (raw)
In-Reply-To: <1280428952-14151-1-git-send-email-xiaosuo@gmail.com>
On Fri, Jul 30, 2010 at 02:42:32AM +0800, Changli Gao wrote:
> act_nat uses its flags field to determine where it acts. It isn't reliable,
> and can't prevent users from doing wrong settings, and act_nat should get the
> position info from skb->tc_verd as act_mirred does.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Nack, the direction controls whether we NAT saddr or daddr. It's
perfectly OK for someone to NAT daddr on the way out.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2010-07-30 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 18:42 [PATCH] act_nat: get the position info from skb->tc_verd Changli Gao
2010-07-30 2:36 ` Herbert Xu [this message]
2010-07-30 2:57 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100730023649.GA5798@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox