From: Stephen Hemminger <shemminger@vyatta.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: stephen.hemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] netem: fix installs of dist files
Date: Sat, 31 Jul 2010 19:33:22 -0700 [thread overview]
Message-ID: <20100731193322.063f0fa5@nehalam> (raw)
In-Reply-To: <1276131129-18079-1-git-send-email-vapier@gentoo.org>
On Wed, 9 Jun 2010 20:52:09 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> The tc program searches LIBDIR by default for the .dist files, and that
> defaults to /usr/lib. But the netem subdir has /lib/ hardcoded which
> means the default build+install results in the files not being found.
>
> Further, these are plain text files which are read at runtime, so it
> doesn't make sense to give them executable bits.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> netem/Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/netem/Makefile b/netem/Makefile
> index b6ccfc6..e52e125 100644
> --- a/netem/Makefile
> +++ b/netem/Makefile
> @@ -20,9 +20,9 @@ stats: stats.c
> $(HOSTCC) $(CCOPTS) -I../include -o $@ $@.c -lm
>
> install: all
> - mkdir -p $(DESTDIR)/lib/tc
> + mkdir -p $(DESTDIR)$(LIBDIR)/tc
> for i in $(DISTDATA); \
> - do install -m 755 $$i $(DESTDIR)/lib/tc; \
> + do install -m 644 $$i $(DESTDIR)$(LIBDIR)/tc; \
> done
>
> clean:
Applied
prev parent reply other threads:[~2010-08-01 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 0:52 [PATCH] netem: fix installs of dist files Mike Frysinger
2010-08-01 2:33 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100731193322.063f0fa5@nehalam \
--to=shemminger@vyatta.com \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).