From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: krkumar2@in.ibm.com, arnd@arndb.de, netdev@vger.kernel.org,
mst@redhat.com
Subject: Re: [PATCH] Multiqueue macvtap driver
Date: Sun, 01 Aug 2010 00:34:06 -0700 (PDT) [thread overview]
Message-ID: <20100801.003406.02275545.davem@davemloft.net> (raw)
In-Reply-To: <1280603907.13192.353.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sat, 31 Jul 2010 20:18:27 +0100
> On Sat, 2010-07-31 at 19:27 +0530, Krishna Kumar wrote:
> [...]
>> @@ -136,39 +158,68 @@ static void macvtap_put_queue(struct mac
>> }
>>
>> /*
>> - * Since we only support one queue, just dereference the pointer.
>> + * Select a queue based on the rxq of the device on which this packet
>> + * arrived. If the incoming device is not mq, then use our cpu number
>> + * to select a queue. vlan->numvtaps is cached in case it changes
>> + * during the execution of this function.
>> */
> [...]
>
> This can result in reordering if a single-queue device's RX interrupt's
> CPU affinity is changed. We generally try to avoid that. You should
> really use or generate a flow hash. There is code for this in
> net/core/dev.c:get_rps_cpu() which could be factored out into a separate
> function.
Agreed.
next prev parent reply other threads:[~2010-08-01 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-31 13:57 [PATCH] Multiqueue macvtap driver Krishna Kumar
2010-07-31 19:18 ` Ben Hutchings
2010-08-01 7:34 ` David Miller [this message]
2010-08-02 12:37 ` Krishna Kumar2
2010-08-02 13:29 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100801.003406.02275545.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=bhutchings@solarflare.com \
--cc=krkumar2@in.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).