netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 01/14] tg3: Add 5784 ASIC rev to earlier PCIe MPS fix
@ 2010-08-02 21:25 Matt Carlson
  2010-08-02 22:47 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Carlson @ 2010-08-02 21:25 UTC (permalink / raw)
  To: davem; +Cc: netdev, andy, mcarlson

tg3 commit e7126997342560533317d8467e8516119ebcbd21 entitled
"tg3: Preserve PCIe MPS setting for new devs" attempted to ensure the
PCIe link negotiated Maximum Payload Size (MPS) setting was 128 bytes
for all devices that didn't support higher speeds.  The 5784 device was
mistakenly added to this list when it shouldn't have.  This patch
removes the 5784 ASIC rev devices from that list.

Reviewed-by: Benjamin Li <benli@broadcom.com>
Reviewed-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
---
 drivers/net/tg3.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index b26a577..98ca0d2 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -7002,8 +7002,7 @@ static int tg3_chip_reset(struct tg3 *tp)
 		 * Older PCIe devices only support the 128 byte
 		 * MPS setting.  Enforce the restriction.
 		 */
-		if (!(tp->tg3_flags & TG3_FLAG_CPMU_PRESENT) ||
-		    (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5784))
+		if (!(tp->tg3_flags & TG3_FLAG_CPMU_PRESENT))
 			val16 &= ~PCI_EXP_DEVCTL_PAYLOAD;
 		pci_write_config_word(tp->pdev,
 				      tp->pcie_cap + PCI_EXP_DEVCTL,
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next 01/14] tg3: Add 5784 ASIC rev to earlier PCIe MPS fix
  2010-08-02 21:25 [PATCH net-next 01/14] tg3: Add 5784 ASIC rev to earlier PCIe MPS fix Matt Carlson
@ 2010-08-02 22:47 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-02 22:47 UTC (permalink / raw)
  To: mcarlson; +Cc: netdev, andy


All 14 patches applied, thanks Matt.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-02 22:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-02 21:25 [PATCH net-next 01/14] tg3: Add 5784 ASIC rev to earlier PCIe MPS fix Matt Carlson
2010-08-02 22:47 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).