From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
florian@mickler.org
Subject: Re: [net-next-2.6 PATCH 1/3] e1000e: register pm_qos request on hardware activation
Date: Mon, 02 Aug 2010 21:21:13 -0700 (PDT) [thread overview]
Message-ID: <20100802.212113.173851850.davem@davemloft.net> (raw)
In-Reply-To: <20100803002622.4179.31850.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 02 Aug 2010 17:27:00 -0700
> From: Florian Mickler <florian@mickler.org>
>
> The pm_qos_add_request call has to register the pm_qos request with the pm_qos
> susbsystem before first use of the pm_qos request via
> pm_qos_update_request.
>
> As pm_qos changed to use plists there is no benefit in registering and
> unregistering the pm_qos request on ifup/ifdown and thus we move the
> registering into e1000_open and the unregistering in e1000_close.
>
> This fixes the following warning:
...
> Signed-off-by: Florian Mickler <florian@mickler.org>
> Tested-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Tested-by: Jeff Pieper <jeffrey.e.pieper@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2010-08-03 4:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 0:27 [net-next-2.6 PATCH 1/3] e1000e: register pm_qos request on hardware activation Jeff Kirsher
2010-08-03 0:27 ` [net-next-2.6 PATCH 2/3] e1000e: Fix irq_synchronize in MSI-X case Jeff Kirsher
2010-08-03 4:21 ` David Miller
2010-08-03 0:27 ` [net-next-2.6 PATCH 3/3] e1000e: update to workaround for jumbo frames on 82577 Jeff Kirsher
2010-08-03 0:36 ` Jeff Kirsher
2010-08-03 4:21 ` David Miller
2010-08-03 4:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802.212113.173851850.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@novell.com \
--cc=florian@mickler.org \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).