* [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.
@ 2010-07-29 15:51 Henrique Camargo
2010-07-29 16:03 ` Vasiliy Kulikov
2010-07-31 5:20 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Henrique Camargo @ 2010-07-29 15:51 UTC (permalink / raw)
To: David S. Miller, Chaithrika U S, Sriramakrishnan, Kevin Hilman,
Jiri Pirko
Cc: segooon
From: Henrique Camargo
Fixes a typo from "dev" to "ndev" that caused compilation errors.
Signed-off-by: Henrique Camargo <henrique.camargo@ensitec.com.br>
---
drivers/net/davinci_emac.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 25e14d2..b89b7bf 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
struct net_device *ndev = priv->ndev;
u32 cnt;
- if (unlikely(num_tokens && netif_queue_stopped(dev)))
- netif_start_queue(dev);
+ if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+ netif_start_queue(ndev);
for (cnt = 0; cnt < num_tokens; cnt++) {
struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
if (skb == NULL)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.
2010-07-29 15:51 [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros Henrique Camargo
@ 2010-07-29 16:03 ` Vasiliy Kulikov
2010-07-31 5:20 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Vasiliy Kulikov @ 2010-07-29 16:03 UTC (permalink / raw)
To: Henrique Camargo
Cc: David S. Miller, Chaithrika U S, Sriramakrishnan, Kevin Hilman,
Jiri Pirko, netdev, linux-kernel
On Thu, Jul 29, 2010 at 12:51 -0300, Henrique Camargo wrote:
> From: Henrique Camargo
>
> Fixes a typo from "dev" to "ndev" that caused compilation errors.
>
> Signed-off-by: Henrique Camargo <henrique.camargo@ensitec.com.br>
Thanks,
Reviewed-by: Kulikov Vasiliy <segooon@gmail.com>
Also I've checked my other patches of removing private stats, the rest
are ok.
> ---
> drivers/net/davinci_emac.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 25e14d2..b89b7bf 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
> struct net_device *ndev = priv->ndev;
> u32 cnt;
>
> - if (unlikely(num_tokens && netif_queue_stopped(dev)))
> - netif_start_queue(dev);
> + if (unlikely(num_tokens && netif_queue_stopped(ndev)))
> + netif_start_queue(ndev);
> for (cnt = 0; cnt < num_tokens; cnt++) {
> struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
> if (skb == NULL)
> --
> 1.7.0.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros.
2010-07-29 15:51 [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros Henrique Camargo
2010-07-29 16:03 ` Vasiliy Kulikov
@ 2010-07-31 5:20 ` David Miller
2010-08-03 3:10 ` [PATCH] Fixes a typo from "dev" to "ndev" Henrique Camargo
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2010-07-31 5:20 UTC (permalink / raw)
To: henrique.camargo
Cc: chaithrika, srk, khilman, jpirko, netdev, linux-kernel, segooon
From: Henrique Camargo <henrique.camargo@ensitec.com.br>
Date: Thu, 29 Jul 2010 12:51:49 -0300
> From: Henrique Camargo
>From lines need valid email addresses. But in this case since you
are the person who wrote the patch, adding another From: tag in
the message body is superfluous and you can just omit it.
> diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
> index 25e14d2..b89b7bf 100644
> --- a/drivers/net/davinci_emac.c
> +++ b/drivers/net/davinci_emac.c
> @@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
> struct net_device *ndev = priv->ndev;
> u32 cnt;
>
> - if (unlikely(num_tokens && netif_queue_stopped(dev)))
> - netif_start_queue(dev);
> + if (unlikely(num_tokens && netif_queue_stopped(ndev)))
> + netif_start_queue(ndev);
Your patch is corrupted, tab characters have been turned into spaces by
your email client.
This makes your patch unusable.
Please fix up these errors and resubmit your patch.
Thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Fixes a typo from "dev" to "ndev"
2010-07-31 5:20 ` David Miller
@ 2010-08-03 3:10 ` Henrique Camargo
2010-08-03 5:03 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Henrique Camargo @ 2010-08-03 3:10 UTC (permalink / raw)
To: David Miller
Cc: chaithrika, srk, khilman, jpirko, netdev, linux-kernel, segooon
The typo was causing compilation errors since "dev" was not defined.
Signed-off-by: Henrique Camargo <henrique.camargo@ensitec.com.br>
---
drivers/net/davinci_emac.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 25e14d2..b89b7bf 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -1182,8 +1182,8 @@ static int emac_net_tx_complete(struct emac_priv *priv,
struct net_device *ndev = priv->ndev;
u32 cnt;
- if (unlikely(num_tokens && netif_queue_stopped(dev)))
- netif_start_queue(dev);
+ if (unlikely(num_tokens && netif_queue_stopped(ndev)))
+ netif_start_queue(ndev);
for (cnt = 0; cnt < num_tokens; cnt++) {
struct sk_buff *skb = (struct sk_buff *)net_data_tokens[cnt];
if (skb == NULL)
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-03 5:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-29 15:51 [PATCH] drivers: Fixes a typo from "dev" to "ndev" that caused compilation erros Henrique Camargo
2010-07-29 16:03 ` Vasiliy Kulikov
2010-07-31 5:20 ` David Miller
2010-08-03 3:10 ` [PATCH] Fixes a typo from "dev" to "ndev" Henrique Camargo
2010-08-03 5:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).