From: Arnd Bergmann <arnd@arndb.de>
To: Krishna Kumar2 <krkumar2@in.ibm.com>
Cc: bhutchings@solarflare.com, davem@davemloft.net, mst@redhat.com,
netdev@vger.kernel.org, therbert@google.com
Subject: Re: [PATCH v2 2/2] macvtap: Implement multiqueue macvtap driver
Date: Mon, 2 Aug 2010 18:34:26 +0200 [thread overview]
Message-ID: <201008021834.26688.arnd@arndb.de> (raw)
In-Reply-To: <OFE0F15F8D.2C34C2AD-ON65257773.00579311-65257773.005A60A9@in.ibm.com>
On Monday 02 August 2010, Krishna Kumar2 wrote:
> "include/linux/if_macvlan.h:57: error: braced-group within expression
> allowed only inside a function"
> Please let me know if there is any alternative (curly braces cannot be
> used outside of functions). Otherwise one change required is to add:
>
> #ifndef MIN
> #endif
>
> I will wait for a few hours and resubmit the patches.
Maybe just open-code the minimum computation:
#define MAX_MACVTAP_QUEUES (NR_CPUS < 16 ? NR_CPUS : 16)
ARnd
prev parent reply other threads:[~2010-08-02 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 14:33 [PATCH v2 1/2] core: Factor out flow calculation from get_rps_cpu Krishna Kumar
2010-08-02 14:33 ` [PATCH v2 2/2] macvtap: Implement multiqueue macvtap driver Krishna Kumar
2010-08-02 15:52 ` Arnd Bergmann
2010-08-02 16:28 ` Krishna Kumar2
2010-08-02 16:34 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008021834.26688.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).