From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: jeremy@goop.org, Xen-devel@lists.xensource.com,
Ian.Campbell@citrix.com, eric.dumazet@gmail.com,
netdev@vger.kernel.org, dongxiao.xu@intel.com, kaber@trash.net
Subject: Re: softirq warnings when calling dev_kfree_skb_irq - bug in conntrack?
Date: Tue, 03 Aug 2010 00:23:18 -0700 (PDT) [thread overview]
Message-ID: <20100803.002318.209965574.davem@davemloft.net> (raw)
In-Reply-To: <1280819074.3874.8.camel@jlt3.sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 03 Aug 2010 09:04:34 +0200
> I had this too:
> http://article.gmane.org/gmane.linux.network/167590
>
> But I'm not convinced it's conntrack, I'd think it's
>
> commit 15e83ed78864d0625e87a85f09b297c0919a4797
> Author: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed May 19 23:16:03 2010 +0000
>
> net: remove zap_completion_queue
>
> which, from the looks of it, ought to be reverted because it failed to
> take into account that dev_kfree_skb() can do more things that require
> non-irq-context than just calling skb->destructor, like for instance the
> conntrack thing we see here.
Agreed. I'll revert this and queue that up for 2.6.35-stable
next prev parent reply other threads:[~2010-08-03 7:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 18:54 softirq warnings when calling dev_kfree_skb_irq - bug in conntrack? Jeremy Fitzhardinge
2010-08-03 7:04 ` Johannes Berg
2010-08-03 7:23 ` David Miller [this message]
2010-08-03 15:24 ` Jeremy Fitzhardinge
2010-08-03 19:16 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803.002318.209965574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=Xen-devel@lists.xensource.com \
--cc=dongxiao.xu@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=jeremy@goop.org \
--cc=johannes@sipsolutions.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).