From: David Miller <davem@davemloft.net>
To: weil@mail.berlios.de
Cc: netdev@vger.kernel.org, chaithrika@ti.com, srk@ti.com,
khilman@deeprootsystems.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] davinci_emac: Fix use after free in davinci_emac_remove
Date: Tue, 03 Aug 2010 21:36:16 -0700 (PDT) [thread overview]
Message-ID: <20100803.213616.48488045.davem@davemloft.net> (raw)
In-Reply-To: <1280861625-4804-1-git-send-email-weil@mail.berlios.de>
From: Stefan Weil <weil@mail.berlios.de>
Date: Tue, 3 Aug 2010 20:53:45 +0200
> free_netdev finally calls kfree which makes the contents
> of ndev and priv (private data contained in ndev) invalid.
>
> So iounmap should be called before free_netdev.
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Chaithrika U S <chaithrika@ti.com>
> Cc: Sriramakrishnan <srk@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
I'll apply this, thanks.
prev parent reply other threads:[~2010-08-04 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 18:53 [PATCH] davinci_emac: Fix use after free in davinci_emac_remove Stefan Weil
2010-08-04 4:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803.213616.48488045.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chaithrika@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=srk@ti.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).