From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] davinci_emac: Fix use after free in davinci_emac_remove Date: Tue, 03 Aug 2010 21:36:16 -0700 (PDT) Message-ID: <20100803.213616.48488045.davem@davemloft.net> References: <1280861625-4804-1-git-send-email-weil@mail.berlios.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, chaithrika@ti.com, srk@ti.com, khilman@deeprootsystems.com, linux-kernel@vger.kernel.org To: weil@mail.berlios.de Return-path: In-Reply-To: <1280861625-4804-1-git-send-email-weil@mail.berlios.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Stefan Weil Date: Tue, 3 Aug 2010 20:53:45 +0200 > free_netdev finally calls kfree which makes the contents > of ndev and priv (private data contained in ndev) invalid. > > So iounmap should be called before free_netdev. > > Cc: David S. Miller > Cc: Chaithrika U S > Cc: Sriramakrishnan > Cc: Kevin Hilman > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Stefan Weil I'll apply this, thanks.