From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org,
xiaohui.xin@intel.com
Subject: Re: [PATCH] Fix napi_gro_frags vs netpoll path
Date: Thu, 05 Aug 2010 12:01:43 -0700 (PDT) [thread overview]
Message-ID: <20100805.120143.91362250.davem@davemloft.net> (raw)
In-Reply-To: <20100805114944.GA21894@ff.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Thu, 5 Aug 2010 11:49:44 +0000
> On Thu, Aug 05, 2010 at 07:40:59PM +0800, Herbert Xu wrote:
>> On Thu, Aug 05, 2010 at 11:03:55AM +0000, Jarek Poplawski wrote:
>> >
>> > The netpoll_rx_on() check in dev_gro_receive() skips part of the
>> > "common" GRO_NORMAL path, especially "pull:" in dev_gro_receive(),
>> > where at least eth header should be copied for entirely paged skbs.
>> >
>> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
>>
>> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> I hope, David will use it with a nearby v2 (the changelog fixed).
I will :-)
prev parent reply other threads:[~2010-08-05 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 11:03 [PATCH] Fix napi_gro_frags vs netpoll path Jarek Poplawski
2010-08-05 11:40 ` Herbert Xu
2010-08-05 11:49 ` Jarek Poplawski
2010-08-05 19:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805.120143.91362250.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiaohui.xin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).