netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] usbnet: remove noisy and hardly useful printk
@ 2010-08-05  8:14 Christian Samsel
  2010-08-05 20:21 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Samsel @ 2010-08-05  8:14 UTC (permalink / raw)
  To: netdev; +Cc: dhollis, Christian Samsel

With turned on hspa modem (Dell 5530 internal card) and activated usb auto
suspend, my system gets up 100 "usbnet_resume has delayed data" per
minute. I didnt noticed any pathological behaviour, so just drop
this message. if any objections, please at least change it to _DEBUG.

Signed-off-by: Christian Samsel <christian.samsel@rwth-aachen.de>
---
 drivers/net/usb/usbnet.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 3b03794..7f62e2d 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1457,7 +1457,6 @@ int usbnet_resume (struct usb_interface *intf)
 		spin_lock_irq(&dev->txq.lock);
 		while ((res = usb_get_from_anchor(&dev->deferred))) {
 
-			printk(KERN_INFO"%s has delayed data\n", __func__);
 			skb = (struct sk_buff *)res->context;
 			retval = usb_submit_urb(res, GFP_ATOMIC);
 			if (retval < 0) {
-- 
1.7.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usbnet: remove noisy and hardly useful printk
  2010-08-05  8:14 [PATCH] usbnet: remove noisy and hardly useful printk Christian Samsel
@ 2010-08-05 20:21 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-05 20:21 UTC (permalink / raw)
  To: christian.samsel; +Cc: netdev, dhollis

From: Christian Samsel <christian.samsel@rwth-aachen.de>
Date: Thu, 05 Aug 2010 10:14:36 +0200

> With turned on hspa modem (Dell 5530 internal card) and activated usb auto
> suspend, my system gets up 100 "usbnet_resume has delayed data" per
> minute. I didnt noticed any pathological behaviour, so just drop
> this message. if any objections, please at least change it to _DEBUG.
> 
> Signed-off-by: Christian Samsel <christian.samsel@rwth-aachen.de>

I agree, and I'll apply this, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-05 20:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-05  8:14 [PATCH] usbnet: remove noisy and hardly useful printk Christian Samsel
2010-08-05 20:21 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).