From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Ira W. Snyder" <iws@ovro.caltech.edu>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
Zang Roy <r61911@freescale.com>,
netdev@vger.kernel.org
Subject: Re: Using virtio as a physical (wire-level) transport
Date: Fri, 6 Aug 2010 00:30:50 +0300 [thread overview]
Message-ID: <20100805213050.GA24984@redhat.com> (raw)
In-Reply-To: <20100804230441.GJ23951@ovro.caltech.edu>
Hi Ira,
> Making my life harder since the last time I tried this, mainline commit
> 7c5e9ed0c (virtio_ring: remove a level of indirection) has removed the
> possibility of using an alternative virtqueue implementation. The commit
> message suggests that you might be willing to add this capability back.
> Would this be an option?
Sorry about that.
With respect to this commit, we only had one implementation upstream
and extra levels of indirection made extending the API
much harder for no apparent benefit.
When there's more than one ring implementation with very small amount of
common code, I think that it might make sense to readd the indirection
back, to separate the code cleanly.
OTOH if the two implementations share a lot of code, I think that it
might be better to just add a couple of if statements here and there.
This way compiler even might have a chance to compile the code out if
the feature is disabled in kernel config.
--
MST
next prev parent reply other threads:[~2010-08-05 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 23:04 Using virtio as a physical (wire-level) transport Ira W. Snyder
2010-08-05 21:30 ` Michael S. Tsirkin [this message]
2010-08-05 23:01 ` Ira W. Snyder
2010-08-05 23:20 ` Michael S. Tsirkin
2010-08-06 15:34 ` Ira W. Snyder
2010-08-14 11:34 ` Alexander Graf
2010-08-16 0:19 ` Rusty Russell
2010-09-06 11:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805213050.GA24984@redhat.com \
--to=mst@redhat.com \
--cc=iws@ovro.caltech.edu \
--cc=netdev@vger.kernel.org \
--cc=r61911@freescale.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).