* [patch] isdn: gigaset: add missing unlock
@ 2010-08-06 8:23 Dan Carpenter
2010-08-08 6:04 ` David Miller
2010-08-08 12:50 ` Tilman Schmidt
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-08-06 8:23 UTC (permalink / raw)
To: Hansjoerg Lipp
Cc: Tilman Schmidt, Karsten Keil, David S. Miller, Andy Shevchenko,
gigaset307x-common, netdev, kernel-janitors
We should unlock here. This is the only place where we return from the
function with the lock held. The caller isn't expecting it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
index e5ea344..bcc174e 100644
--- a/drivers/isdn/gigaset/capi.c
+++ b/drivers/isdn/gigaset/capi.c
@@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
do {
if (bcap->bcnext == ap) {
bcap->bcnext = bcap->bcnext->bcnext;
+ spin_unlock_irqrestore(&bcs->aplock, flags);
return;
}
bcap = bcap->bcnext;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] isdn: gigaset: add missing unlock
2010-08-06 8:23 [patch] isdn: gigaset: add missing unlock Dan Carpenter
@ 2010-08-08 6:04 ` David Miller
2010-08-08 12:50 ` Tilman Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-08-08 6:04 UTC (permalink / raw)
To: error27
Cc: hjlipp, tilman, isdn, ext-andriy.shevchenko, gigaset307x-common,
netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Fri, 6 Aug 2010 10:23:23 +0200
> We should unlock here. This is the only place where we return from the
> function with the lock held. The caller isn't expecting it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] isdn: gigaset: add missing unlock
2010-08-06 8:23 [patch] isdn: gigaset: add missing unlock Dan Carpenter
2010-08-08 6:04 ` David Miller
@ 2010-08-08 12:50 ` Tilman Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: Tilman Schmidt @ 2010-08-08 12:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Hansjoerg Lipp, Karsten Keil, David S. Miller, Andy Shevchenko,
gigaset307x-common, netdev, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
Am 06.08.2010 10:23 schrieb Dan Carpenter:
> We should unlock here. This is the only place where we return from the
> function with the lock held. The caller isn't expecting it.
Thanks, good catch.
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
>
> diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
> index e5ea344..bcc174e 100644
> --- a/drivers/isdn/gigaset/capi.c
> +++ b/drivers/isdn/gigaset/capi.c
> @@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
> do {
> if (bcap->bcnext == ap) {
> bcap->bcnext = bcap->bcnext->bcnext;
> + spin_unlock_irqrestore(&bcs->aplock, flags);
> return;
> }
> bcap = bcap->bcnext;
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-08 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-06 8:23 [patch] isdn: gigaset: add missing unlock Dan Carpenter
2010-08-08 6:04 ` David Miller
2010-08-08 12:50 ` Tilman Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).