From: David Miller <davem@davemloft.net>
To: dp@highloadlab.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, kaber@trash.net,
yoshfuji@linux-ipv6.org, pekkas@netcore.fi,
gilad@codefidence.com, yony@comsleep.com, ori@comsleep.com,
ilpo.jarvinen@helsinki.fi, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: no md5sig option size check bug
Date: Sat, 07 Aug 2010 20:24:16 -0700 (PDT) [thread overview]
Message-ID: <20100807.202416.124037373.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTimHMAwi158ycRh_nRYPYUTSkww-psdFai-LsTsb@mail.gmail.com>
From: Dmitry Popov <dp@highloadlab.com>
Date: Sat, 7 Aug 2010 23:17:52 +0400
> From: Dmitry Popov <dp@highloadlab.com>
>
> tcp_parse_md5sig_option doesn't check md5sig option (TCPOPT_MD5SIG)
> length, but tcp_v[46]_inbound_md5_hash assume that it's at least 16
> bytes long.
>
> Signed-off-by: Dmitry Popov <dp@highloadlab.com>
I'll apply this, but the memcmp() we do against this pointer is always
safe because there's at least skb_shared_info()'s worth of valid
memory past skb->data guarenteed at all times which is much larger
than 16 bytes.
So at worst we'd access garbage, but never past a valid piece of
allocated memory.
Thanks.
prev parent reply other threads:[~2010-08-08 3:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 19:17 [PATCH] tcp: no md5sig option size check bug Dmitry Popov
2010-08-08 3:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100807.202416.124037373.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dp@highloadlab.com \
--cc=gilad@codefidence.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ori@comsleep.com \
--cc=pekkas@netcore.fi \
--cc=yony@comsleep.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).