From: David Miller <davem@davemloft.net>
To: dwmw2@infradead.org
Cc: netdev@vger.kernel.org, nathan@traverse.com.au,
linux-atm-general@lists.sourceforge.net
Subject: Re: [PATCH] solos-pci: Fix race condition in tasklet RX handling
Date: Sat, 07 Aug 2010 23:02:22 -0700 (PDT) [thread overview]
Message-ID: <20100807.230222.63012624.davem@davemloft.net> (raw)
In-Reply-To: <1281111456.2715.29.camel@localhost>
From: David Woodhouse <dwmw2@infradead.org>
Date: Fri, 06 Aug 2010 17:17:36 +0100
> We were seeing faults in the solos-pci receive tasklet when packets
> arrived for a VCC which was currently being closed:
...
> This patch uses an RCU-inspired approach to fix it. In the RX tasklet's
> find_vcc() function we first refuse to use a VCC which already has the
> ATM_VF_READY bit cleared. And in the VCC close function, we synchronise
> with the tasklet to ensure that it can't still be using the VCC before
> we continue and allow the VCC to be destroyed.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
> Tested-by: Nathan Williams <nathan@traverse.com.au>
> Cc: stable@kernel.org
Applied, thanks David.
prev parent reply other threads:[~2010-08-08 6:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 11:16 RX/close vcc race with solos/atmtcp/usbatm/he David Woodhouse
2010-05-26 18:51 ` [Linux-ATM-General] " Stanislaw Gruszka
2010-05-28 10:46 ` David Miller
2010-05-28 13:33 ` David Woodhouse
2010-06-07 10:02 ` David Woodhouse
2010-06-16 0:33 ` Nathan Williams
2010-07-27 23:12 ` Nathan Williams
2010-06-07 13:44 ` [Linux-ATM-General] " Chas Williams (CONTRACTOR)
2010-06-07 14:13 ` David Woodhouse
2010-06-07 15:10 ` Chas Williams (CONTRACTOR)
2010-06-07 16:04 ` David Woodhouse
2010-06-07 16:37 ` Chas Williams (CONTRACTOR)
2010-06-07 20:49 ` David Woodhouse
2010-06-08 15:05 ` Chas Williams (CONTRACTOR)
2010-06-08 16:25 ` David Woodhouse
2010-08-06 16:17 ` [PATCH] solos-pci: Fix race condition in tasklet RX handling David Woodhouse
2010-08-08 6:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100807.230222.63012624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=nathan@traverse.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).