From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bphilips@novell.com,
miltonm@bga.com, anton@samba.org, sonnyrao@us.ibm.com,
stable@kernel.org
Subject: Re: [net-2.6 PATCH] e100/e1000*/igb*/ixgb*: Add missing read memory barrier
Date: Sun, 08 Aug 2010 20:04:03 -0700 (PDT) [thread overview]
Message-ID: <20100808.200403.84396615.davem@davemloft.net> (raw)
In-Reply-To: <20100809020230.1087.42749.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sun, 08 Aug 2010 19:02:31 -0700
> Based on patches from Sonny Rao and Milton Miller...
>
> Combined the patches to fix up clean_tx_irq and clean_rx_irq.
>
> The PowerPC architecture does not require loads to independent bytes
> to be ordered without adding an explicit barrier.
>
> In ixgbe_clean_rx_irq we load the status bit then load the packet data.
> With packet split disabled if these loads go out of order we get a
> stale packet, but we will notice the bad sequence numbers and drop it.
...
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2010-08-09 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 2:02 [net-2.6 PATCH] e100/e1000*/igb*/ixgb*: Add missing read memory barrier Jeff Kirsher
2010-08-09 3:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100808.200403.84396615.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=bphilips@novell.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=miltonm@bga.com \
--cc=netdev@vger.kernel.org \
--cc=sonnyrao@us.ibm.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).