From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin LaHaise Subject: Re: [PATCH] net: allow netdev_wait_allrefs() to run faster Date: Mon, 9 Aug 2010 17:03:11 -0400 Message-ID: <20100809210311.GW30010@kvack.org> References: <4ADB55BC.5020107@gmail.com> <20091018182144.GC23395@kvack.org> <200910211539.01824.opurdila@ixiacom.com> <4ADF2B57.4030708@gmail.com> <20091021165139.GL877@kvack.org> <20091029233848.GV3141@kvack.org> <4C603999.1030801@candelatech.com> <20100809173429.GR30010@kvack.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ben Greear , Eric Dumazet , Octavian Purdila , netdev@vger.kernel.org, Cosmin Ratiu To: "Eric W. Biederman" Return-path: Received: from kanga.kvack.org ([205.233.56.17]:33920 "EHLO kanga.kvack.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754860Ab0HIVDN (ORCPT ); Mon, 9 Aug 2010 17:03:13 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Aug 09, 2010 at 12:59:14PM -0700, Eric W. Biederman wrote: > The network device deletion batching code has gone in, which is > a big help, as have some dev_put deletions, so we hit that 250ms > delay less often. I'll see how much that helps. Odds are I'm going to have to move the device deletion into a separate thread. That should give me a natural boundary to queue up deletions at, which should fix the tunnel-flap and partial tunnel-flap cases I'm worried about. At some point I have to figure out how to get my API needs met by the in-kernel L2TP code, but that's a worry for another day. > sysfs feature wise has now settled down, and the regressions have all > been stamped out so now should be a good time to work on scaling. > > I still have some preliminary patches in my tree, that I will dig up > as time goes by. I should have some time this evening to run a few tests, and hopefully can post some results. -ben