* [PATCH 07/18 v2] isdn: avm: call disable_pci_device() if pci_probe() failed
@ 2010-08-09 19:50 Kulikov Vasiliy
2010-08-10 8:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-08-09 19:50 UTC (permalink / raw)
To: kernel-janitors
Cc: Karsten Keil, David S. Miller, Alexey Dobriyan, Tilman Schmidt,
netdev
Driver should call disable_pci_device() if it returns from pci_probe()
with error.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
drivers/isdn/hardware/avm/t1pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/isdn/hardware/avm/t1pci.c b/drivers/isdn/hardware/avm/t1pci.c
index 5a3f830..a79eb5a 100644
--- a/drivers/isdn/hardware/avm/t1pci.c
+++ b/drivers/isdn/hardware/avm/t1pci.c
@@ -210,6 +210,7 @@ static int __devinit t1pci_probe(struct pci_dev *dev,
if (retval != 0) {
printk(KERN_ERR "t1pci: no AVM-T1-PCI at i/o %#x, irq %d detected, mem %#x\n",
param.port, param.irq, param.membase);
+ pci_disable_device(dev);
return -ENODEV;
}
return 0;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 07/18 v2] isdn: avm: call disable_pci_device() if pci_probe() failed
2010-08-09 19:50 [PATCH 07/18 v2] isdn: avm: call disable_pci_device() if pci_probe() failed Kulikov Vasiliy
@ 2010-08-10 8:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-08-10 8:43 UTC (permalink / raw)
To: segooon; +Cc: kernel-janitors, isdn, adobriyan, tilman, netdev
From: Kulikov Vasiliy <segooon@gmail.com>
Date: Mon, 9 Aug 2010 23:50:47 +0400
> Driver should call disable_pci_device() if it returns from pci_probe()
> with error.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Applied, but as previously mentioned disable_pci_device() is wrong.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-10 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 19:50 [PATCH 07/18 v2] isdn: avm: call disable_pci_device() if pci_probe() failed Kulikov Vasiliy
2010-08-10 8:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).