* [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel.
@ 2010-08-10 17:36 sjur.brandeland
2010-08-10 17:36 ` [PATCH 2/2] caif-spi: Bugfix SPI_DATA_POS settings were inverted sjur.brandeland
2010-08-10 23:39 ` [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel David Miller
0 siblings, 2 replies; 4+ messages in thread
From: sjur.brandeland @ 2010-08-10 17:36 UTC (permalink / raw)
To: davem; +Cc: sjurbren, netdev, Sjur Braendeland
From: Sjur Braendeland <sjur.brandeland@stericsson.com>
Headroom size for control channel must be at least 48 bytes in some scenarios.
Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
---
net/caif/cfpkt_skbuff.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
index 01f238f..c49a669 100644
--- a/net/caif/cfpkt_skbuff.c
+++ b/net/caif/cfpkt_skbuff.c
@@ -9,7 +9,7 @@
#include <linux/hardirq.h>
#include <net/caif/cfpkt.h>
-#define PKT_PREFIX 16
+#define PKT_PREFIX 48
#define PKT_POSTFIX 2
#define PKT_LEN_WHEN_EXTENDING 128
#define PKT_ERROR(pkt, errmsg) do { \
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] caif-spi: Bugfix SPI_DATA_POS settings were inverted.
2010-08-10 17:36 [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel sjur.brandeland
@ 2010-08-10 17:36 ` sjur.brandeland
2010-08-10 23:39 ` David Miller
2010-08-10 23:39 ` [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel David Miller
1 sibling, 1 reply; 4+ messages in thread
From: sjur.brandeland @ 2010-08-10 17:36 UTC (permalink / raw)
To: davem; +Cc: sjurbren, netdev, Sjur Braendeland
From: Sjur Braendeland <sjur.brandeland@stericsson.com>
The setting of SPI_DATA_POS depending on CONFIG_CAIF_SPI_SYNC
where inverted.
Change-Id: I4886d1d69cc50557f516e05c40f649fed55384a2
Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
---
drivers/net/caif/caif_spi_slave.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/caif/caif_spi_slave.c b/drivers/net/caif/caif_spi_slave.c
index 077ccf8..2111dbf 100644
--- a/drivers/net/caif/caif_spi_slave.c
+++ b/drivers/net/caif/caif_spi_slave.c
@@ -22,13 +22,13 @@
#include <net/caif/caif_spi.h>
#ifndef CONFIG_CAIF_SPI_SYNC
-#define SPI_DATA_POS SPI_CMD_SZ
+#define SPI_DATA_POS 0
static inline int forward_to_spi_cmd(struct cfspi *cfspi)
{
return cfspi->rx_cpck_len;
}
#else
-#define SPI_DATA_POS 0
+#define SPI_DATA_POS SPI_CMD_SZ
static inline int forward_to_spi_cmd(struct cfspi *cfspi)
{
return 0;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel.
2010-08-10 17:36 [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel sjur.brandeland
2010-08-10 17:36 ` [PATCH 2/2] caif-spi: Bugfix SPI_DATA_POS settings were inverted sjur.brandeland
@ 2010-08-10 23:39 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-10 23:39 UTC (permalink / raw)
To: sjur.brandeland; +Cc: sjurbren, netdev
From: sjur.brandeland@stericsson.com
Date: Tue, 10 Aug 2010 19:36:46 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> Headroom size for control channel must be at least 48 bytes in some scenarios.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] caif-spi: Bugfix SPI_DATA_POS settings were inverted.
2010-08-10 17:36 ` [PATCH 2/2] caif-spi: Bugfix SPI_DATA_POS settings were inverted sjur.brandeland
@ 2010-08-10 23:39 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-08-10 23:39 UTC (permalink / raw)
To: sjur.brandeland; +Cc: sjurbren, netdev
From: sjur.brandeland@stericsson.com
Date: Tue, 10 Aug 2010 19:36:47 +0200
> From: Sjur Braendeland <sjur.brandeland@stericsson.com>
>
> The setting of SPI_DATA_POS depending on CONFIG_CAIF_SPI_SYNC
> where inverted.
>
> Signed-off-by: Sjur Braendeland <sjur.brandeland@stericsson.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-10 23:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-10 17:36 [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel sjur.brandeland
2010-08-10 17:36 ` [PATCH 2/2] caif-spi: Bugfix SPI_DATA_POS settings were inverted sjur.brandeland
2010-08-10 23:39 ` David Miller
2010-08-10 23:39 ` [PATCH 1/2] caif: Bugfix - Increase default headroom size for control channel David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).