From: Andi Kleen <andi@firstfloor.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Andi Kleen <andi@firstfloor.org>, netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] Don't destroy TCP sockets twice
Date: Tue, 10 Aug 2010 12:32:06 +0200 [thread overview]
Message-ID: <20100810103206.GC6801@basil.fritz.box> (raw)
In-Reply-To: <20100810102421.GA28030@gondor.apana.org.au>
On Tue, Aug 10, 2010 at 06:24:21AM -0400, Herbert Xu wrote:
> On Tue, Aug 10, 2010 at 10:30:40AM +0200, Andi Kleen wrote:
> .
> > This simple patch demonstrates double destroy. I have patches for showing
> > the more complicated case too, but they're much more ugly.
>
> Andi, I know you're seeing the problem, but I need to udnerstand
> why, and this patch doesn't really answer the why part :)
>
> So did you figure out why was calling it first (I presume you
> know who called it the second time since you've got the back
> trace)?
Yes I stored the backtrace of the first caller in the ugly debug
patches and dumped that on the second destroy. It was tcp_done the
first time.
Also did the same for tcp_sk() and there it was the fin sending.
I agree that tcp_close() should skip it in theory but I saw
it anyways :/
-Andi
next prev parent reply other threads:[~2010-08-10 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 11:05 [RFC] [PATCH] Don't destroy TCP sockets twice Andi Kleen
2010-08-09 21:30 ` Herbert Xu
2010-08-10 8:30 ` Andi Kleen
2010-08-10 10:24 ` Herbert Xu
2010-08-10 10:32 ` Andi Kleen [this message]
2010-08-10 10:39 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810103206.GC6801@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).