From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Philip Rakity <prakity@marvell.com>
Cc: Sachin Sanap <ssanap@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ashish Karkare <akarkare@marvell.com>,
Prabhanjan Sarnaik <sarnaik@marvell.com>,
"eric.y.miao@gmail.com" <eric.y.miao@gmail.com>,
Mark Brown <markb@marvell.com>
Subject: Re: [PATCH] net: add Fast Ethernet driver for PXA168.
Date: Tue, 10 Aug 2010 13:40:32 +0200 [thread overview]
Message-ID: <20100810114032.GO8876@mail.wantstofly.org> (raw)
In-Reply-To: <26AE03C2-9D1A-4E63-82E3-DD47BD451B70@marvell.com>
On Fri, Aug 06, 2010 at 08:44:02AM -0700, Philip Rakity wrote:
> You should change
>
> >>> + skb = dev_alloc_skb(MAX_PKT_SIZE + ETH_HW_IP_ALIGN);
>
> >>
>
> to allocatie ADDITIONAL prepend space in the header. If you are doing
> ethernet to 802.11 routing or bridging then the wireless driver will
> not have enough space in front of the header to prepend its headers
> without having to allocate additional space.
This seems like something that, should you want to handle it, should be
handled centrally (e.g. by conditionally increasing NET_SKB_PAD or so)
and not hardcoded into one specific driver only.
next prev parent reply other threads:[~2010-08-10 11:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 10:47 [PATCH] net: add Fast Ethernet driver for PXA168 Sachin Sanap
2010-08-04 6:58 ` Lennert Buytenhek
2010-08-04 7:08 ` Eric Miao
2010-08-04 7:09 ` Eric Miao
2010-08-04 7:17 ` Lennert Buytenhek
2010-08-04 7:56 ` Simon Horman
2010-08-06 15:14 ` Sachin Sanap
2010-08-06 15:44 ` Philip Rakity
2010-08-06 16:55 ` Sachin Sanap
2010-08-06 17:02 ` Joe Perches
2010-08-10 11:40 ` Lennert Buytenhek [this message]
2010-08-06 18:02 ` Philip Rakity
2010-08-10 8:30 ` [PATCH v2] " Sachin Sanap
2010-08-10 12:33 ` Lennert Buytenhek
2010-08-10 16:24 ` Philip Rakity
2010-08-10 17:30 ` Lennert Buytenhek
2010-08-10 17:55 ` Philip Rakity
2010-08-10 18:01 ` Lennert Buytenhek
2010-08-10 18:12 ` Philip Rakity
2010-08-10 23:42 ` David Miller
2010-08-14 7:08 ` Sachin Sanap
2010-08-14 7:22 ` [PATCH v3] " Sachin Sanap
2010-08-14 20:47 ` Philip Rakity
2010-08-16 10:07 ` Sachin Sanap
-- strict thread matches above, loose matches on Subject: below --
2010-08-06 19:39 [PATCH] " Sachin Sanap
2010-08-06 15:18 ` Sachin Sanap
2010-08-06 15:26 ` Sachin Sanap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810114032.GO8876@mail.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=akarkare@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=markb@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=prakity@marvell.com \
--cc=sarnaik@marvell.com \
--cc=ssanap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).