From: Herbert Xu <herbert@gondor.apana.org.au>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>,
Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org
Subject: Re: Yet another bridge netfilter crash
Date: Tue, 10 Aug 2010 11:19:19 -0400 [thread overview]
Message-ID: <20100810151919.GA30450@gondor.apana.org.au> (raw)
In-Reply-To: <AANLkTikpCOrkPqOkahXBFFoH6bqTKhA-+_mUy0qGrRnq@mail.gmail.com>
On Tue, Aug 10, 2010 at 06:39:42AM +0800, Changli Gao wrote:
>
> How about always using the skb->nf_bridge of the skb last received in
> a defrag queue as the nf_bridge of the final defraged skb? I have
> posted a patch doing such thing.
> http://patchwork.ozlabs.org/patch/60904/
I'd rather just drop the fragment (and maybe fail the whole
reassembly) if you detect nf_bridge mismatches.
Reassembling fragments from two interfaces is one thing, but
knowingly reassembling fragments across two bridges is just
wrong.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2010-08-10 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 13:42 Yet another bridge netfilter crash Herbert Xu
2010-07-23 14:18 ` Patrick McHardy
2010-07-23 15:00 ` Herbert Xu
2010-07-23 15:17 ` Patrick McHardy
2010-07-23 15:26 ` Herbert Xu
2010-08-04 16:30 ` Patrick McHardy
2010-08-04 16:41 ` Herbert Xu
2010-08-04 16:50 ` Patrick McHardy
2010-08-09 21:42 ` Herbert Xu
2010-08-09 22:39 ` Changli Gao
2010-08-10 15:19 ` Herbert Xu [this message]
2010-08-04 23:00 ` Changli Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100810151919.GA30450@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).